From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [RFC PATCH] Changes to pop-up source buffers Date: Sun, 19 Jan 2020 13:07:03 +0800 Message-ID: <87a76k2fwo.fsf@gmail.com> References: <87eevw7jqk.fsf@gmail.com> Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:33503) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1it2nv-0005ne-BB for emacs-orgmode@gnu.org; Sun, 19 Jan 2020 00:07:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1it2nr-0006fI-PA for emacs-orgmode@gnu.org; Sun, 19 Jan 2020 00:07:19 -0500 Received: from [183.246.141.113] (port=11231 helo=dark.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1it2nq-0006Vf-Bf for emacs-orgmode@gnu.org; Sun, 19 Jan 2020 00:07:15 -0500 In-reply-to: <87eevw7jqk.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org > A final advantage I'd like to note for pop-to-buffer and > quit-restore-window, is that these are the mechanisms used by many > built-in Emacs functions to pop up and close windows, such as *Help* > windows. I agree to use =pop-to-buffer=. Propose too. > > There was one previous option for org-src-window-setup, > reorganize-frame, that I couldn't reimplement using pop-to-buffer. That > option required keeping around some logic for deleting windows and > restoring the configuration. > > I tested the new implementation for org-src-switch-to-buffer, for all > options of org-src-window-setup, and it appears to work correctly. I > tested this on Emacs 26.3. -- [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3