From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qPZPBzsUGV9pSwAA0tVLHw (envelope-from ) for ; Thu, 23 Jul 2020 04:38:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ENckAzsUGV9NLAAA1q6Kng (envelope-from ) for ; Thu, 23 Jul 2020 04:38:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 27E73940704 for ; Thu, 23 Jul 2020 04:38:18 +0000 (UTC) Received: from localhost ([::1]:51310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jySzn-00030p-PJ for larch@yhetil.org; Thu, 23 Jul 2020 00:38:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jySzP-0002yQ-Dw for emacs-orgmode@gnu.org; Thu, 23 Jul 2020 00:37:51 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:53274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jySzN-0002N4-Bu for emacs-orgmode@gnu.org; Thu, 23 Jul 2020 00:37:50 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 43960D6C55; Thu, 23 Jul 2020 00:37:46 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=mH8489EHZjq3VLIRpC0eccvZjgc=; b=A/oGPH pZs2LL9lKn6y0vBqcDud1/O0Ct1sx2wh/mVF2irT+w6og48Sbw0sgRc748KTKjR+ HWHzrNbKeoZRh8iav7DOKEeAXeVOcUmMEuAXI95IYLbvQFENVbPXOlblXa3rRsZc 7kv+a8EY3IIxPCpO4mqYcMqUkiuPrj/sj/RKA= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 3D031D6C54; Thu, 23 Jul 2020 00:37:46 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=xgvvBH5v5QoTa1Ova91X1osC83Z++UFpgClfr8qTT+k=; b=bneL1zJ5EciPIn5yKsWY75XrI9DylujaPUDC0HJ8dzYBvCvDF9y8nDH852/92Ak28fsvAy8HN9zkCwDUMqRo0HWJfYUvTb/ovLzepQxPff0PodeUqnaQ8YcblsV9sBCDJW+6D4Rhs01/FL3my2c1UoQbt8Vi4Rm/2FExsYBWq8Y= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id B514AD6C22; Thu, 23 Jul 2020 00:37:43 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Clemens Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command In-Reply-To: References: <87imegyy2r.fsf@kyleam.com> Date: Thu, 23 Jul 2020 00:37:42 -0400 Message-ID: <87a6zqzw15.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 3FEC25D4-CC9E-11EA-A17D-F0EA2EB3C613-24757444!pb-smtp20.pobox.com Received-SPF: pass client-ip=173.228.157.52; envelope-from=kyle@kyleam.com; helo=pb-smtp20.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 23:40:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=A/oGPH p; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=bneL1zJ5; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: bmBwPb9ZdYY2 Clemens writes: > Now that I know that completion works for multiple tags with default > completion I'm unsure if it is worth to proceed with this. I wondered > how this would go unnoticed for such a long time in org and now I know > that the failure was on my part. On the other hand switching to > `completing-read-multiple` would improve the situation for completion > frameworks which handle it correctly and would also be more idiomatic > for this use case. Yeah, I'm also undecided. I'm open to the idea of moving from org-tags-completion-function to crm for the reason you give, but, with any proposal for that, I think it'd be important to see an inspection of the current call sites (only a handful) and an analysis of whether we can retain the current behavior. Then again, this isn't the only place that passes a function for completing-read's COLLECTION argument: there's also org-agenda-filter-completion-function. At a glance I think it would be harder to replace with crm. But perhaps we could at least avoid some confusion by explicitly documenting spots where completion frameworks may interact with the intended completion functionality.