From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QH0lE4t9R18lTgAA0tVLHw (envelope-from ) for ; Thu, 27 Aug 2020 09:31:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MHH6Dot9R1+BZAAAB5/wlQ (envelope-from ) for ; Thu, 27 Aug 2020 09:31:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF9959401AE for ; Thu, 27 Aug 2020 09:31:54 +0000 (UTC) Received: from localhost ([::1]:60500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBEG9-0001BD-0Q for larch@yhetil.org; Thu, 27 Aug 2020 05:31:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBEFb-0001A7-SD for emacs-orgmode@gnu.org; Thu, 27 Aug 2020 05:31:19 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBEFZ-0004P1-Vg for emacs-orgmode@gnu.org; Thu, 27 Aug 2020 05:31:19 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 5B83C1C0006; Thu, 27 Aug 2020 09:31:15 +0000 (UTC) From: Nicolas Goaziou To: Anders Johansson Subject: Re: [PATCH] Fix bug in org-num check for commented headlines References: Mail-Followup-To: Anders Johansson , emacs-orgmode@gnu.org Date: Thu, 27 Aug 2020 11:31:14 +0200 In-Reply-To: (Anders Johansson's message of "Tue, 25 Aug 2020 15:55:45 +0200") Message-ID: <87a6ygbfkt.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.183.197; envelope-from=mail@nicolasgoaziou.fr; helo=relay5-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 05:31:15 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 10Ioiqs7hgdt Hello, Anders Johansson writes: > I found an easily solved bug in org-num. > > This happens when org-num-skip-commented is non-nil. > When creating a new headline, often org-num--skip-value is invoked > before any headline text is created. This means that =E2=80=98title=E2=80= =98 is nil > and the string-match check breaks. Checking if title is non-nil fixes > this. Applied. Thank you. Regards, --=20 Nicolas Goaziou