From: Kyle Meyer <kyle@kyleam.com>
To: Christian Garbs <mitch@cgarbs.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] testing/lisp/test-org-archive.el: Fix test
Date: Thu, 14 Jan 2021 05:22:48 GMT [thread overview]
Message-ID: <87a6tc5byx.fsf@kyleam.com> (raw)
In-Reply-To: <20210113220939.sbkhyefniyvsypah@cgarbs.de>
Christian Garbs via "General discussions about Org-mode." writes:
> Hello,
>
> I've run across a test error on the current HEAD.
> When I run "make test" on my system, then test-org-archive/datetree
> fails.
>
> The test fails because the expected output should contain "Sunday",
> but with a German locale the generated text is "Sonntag" instead
> (which is the German translation of "Sunday").
Ah, that was dumb on my part.
> Subject: [PATCH] testing/lisp/test-org-archive.el: Fix test
>
> * testing/lisp/test-org-archive.el
> (test-org-archive/datetree): Fix test for locales that don't use
> English weekday names.
> ---
> testing/lisp/test-org-archive.el | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/testing/lisp/test-org-archive.el b/testing/lisp/test-org-archive.el
> index 71ab427d2..d24a54794 100644
> --- a/testing/lisp/test-org-archive.el
> +++ b/testing/lisp/test-org-archive.el
> @@ -63,7 +63,7 @@
> ;; Test in buffer target with no additional subheadings...
> (should
> (string-match-p
> - (regexp-quote "*** 2020-07-05 Sunday\n**** a")
> + (regexp-quote (format-time-string "*** 2020-07-05 %A\n**** a"))
Works for me. Another option would be to let-bind system-time-locale.
Applied (d02c0218e). Thank you.
prev parent reply other threads:[~2021-01-14 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 22:09 [PATCH] testing/lisp/test-org-archive.el: Fix test Christian Garbs via General discussions about Org-mode.
2021-01-14 5:22 ` Kyle Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6tc5byx.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=mitch@cgarbs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).