From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UFFUCq+f4mL9AQAAbAwnHQ (envelope-from ) for ; Thu, 28 Jul 2022 16:39:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2EBgCa+f4mJgXgEAG6o9tA (envelope-from ) for ; Thu, 28 Jul 2022 16:39:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 01DD02A934 for ; Thu, 28 Jul 2022 16:39:43 +0200 (CEST) Received: from localhost ([::1]:52146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oH4ft-0002ZM-SB for larch@yhetil.org; Thu, 28 Jul 2022 10:39:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH4bs-0007fp-RK for emacs-orgmode@gnu.org; Thu, 28 Jul 2022 10:35:34 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:43983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oH4bq-0006sz-Lc for emacs-orgmode@gnu.org; Thu, 28 Jul 2022 10:35:31 -0400 Received: by mail-pj1-x1030.google.com with SMTP id o5-20020a17090a3d4500b001ef76490983so2365921pjf.2 for ; Thu, 28 Jul 2022 07:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=kp0YlE8EeGaNLOFFw7YQGbIPSpMb5ykRZlggoVCDyLw=; b=Pok5iJ89KMHUCsssecdsCnz67N7WjnAVR2NdzNCg384Frcr1/Kw5SXb+kDrUvicuhk m8R+eWhK7jnDnVkfyEjieT5detIaehEcEipXmkv8kx891L3Ku5xOXpWUwv8bnRceRHqB 8O9+ldhJ9WOaY7l+pS7Y6YSehDrI880dVq+v7POnFGnVNBPyLb2LK1RbffFzcRuxQL5G LIhW3ZCjyzFcCGOP0rsWEhXh0Mi8cEvowidUItYNDjmO8PNZte3hjcvjCYD4WNYkBDhG Iql2GjuLCrfjSlU/B0fUGSkWeQBpW3677muM+fe6wKgKBdkLfmNNg0so5XoanLUXeQUg cEpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=kp0YlE8EeGaNLOFFw7YQGbIPSpMb5ykRZlggoVCDyLw=; b=0hfm75ijkBRksWlrc2YA1+eAhqMDwuTL4uzyW7sXrVVXL4Mig6DX4kyMmymERxkUN1 oPqrconHMCrM1dOTT9jbC7q2j5mKdTcvpjK1mkoyROB/7SuifBprlqPXEfyYZ9IAyc3W VBAQYv4F/TPQRUAJex/0hqDOnVujgP0EwXRoZ4A96U6NaTIFDYqEmRJGtzfsVLQQm7IX Rg/MrTBto4XqOxF85z35J4piLBNFKvY2Oc40tQZSby4jwC1WeGIO8oS2inTAU8JNmNUc sYIO6dv6VSuKseaRjOGm08qZUtYhj4NqUm1YMPFijtxRFFWWi66yXZldujXPMS88N6Zp cYCA== X-Gm-Message-State: AJIora8FBZs2TqtubkjkAO+cthL9esZm/l7oDM42hoyIuw+QTUwIqao+ qZL74k3UCx81spzjNgJSJhuXQFCixy0= X-Google-Smtp-Source: AGRyM1vpKu6WQR+S84ADEfBGtyC/KKHYzQ4gQ6u5lghWBit4a+Yn2iKGgAFzcSs64KpbztjuGImUBw== X-Received: by 2002:a17:90b:48c7:b0:1f2:dcca:f8c7 with SMTP id li7-20020a17090b48c700b001f2dccaf8c7mr10695744pjb.156.1659018927898; Thu, 28 Jul 2022 07:35:27 -0700 (PDT) Received: from localhost ([2409:8a70:217:4f80:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id f4-20020a170902ce8400b0015e8d4eb1d5sm1463799plg.31.2022.07.28.07.35.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 07:35:26 -0700 (PDT) From: Ihor Radchenko To: Joseph Turner Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/ob-plantuml.el: Insert results in buffer In-Reply-To: <87h732w5og.fsf@breatheoutbreathe.in> References: <20220719231520.100206-1-joseph@breatheoutbreathe.in> <87bktduydf.fsf@localhost> <87o7xdot4d.fsf@breatheoutbreathe.in> <877d40ctho.fsf@localhost> <87h732w5og.fsf@breatheoutbreathe.in> Date: Thu, 28 Jul 2022 22:36:31 +0800 Message-ID: <87a68t9uds.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=yantar92@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" Authentication-Results: aspmx1.migadu.com; none X-Migadu-Scanner: scn1.migadu.com X-TUID: upOQHddXUj6I Joseph Turner writes: > Ihor Radchenko writes: >> You can examine :result-params property inside params plist. If that >> property does not explicitly mention different results Type (see 16.6 >> Results of Evaluation), ob-plantuml may set the type to "file" with >> plist-put. > > Perhaps I'm confused, but I think org-babel-default-header-args:plantuml > is actually an alist, right? Yes, you are right indeed. > I tried removing the (:results . "file") from > org-babel-default-header-args:plantuml, and then overwriting the params > argument inside the let* block like so: > > ``` > (let* ((do-export (cdr (assq :file params))) > (params (if do-export > (add-to-list 'params '(:results . "file"))) > (out-file ... > ``` > > Logging the params variable after the let* block reveals that :results > is set to "file", but I still get "Code block produced no output" when > I try to evaluate the plantuml org src block. > > Thoughts? You also need to change :result-params and :result-type. See `org-babel-execute-src-block'. Best, Ihor