From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kD4tBJz7lmMtAAAAbAwnHQ (envelope-from ) for ; Mon, 12 Dec 2022 10:59:56 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IMXpA5z7lmNWfAEAauVa8A (envelope-from ) for ; Mon, 12 Dec 2022 10:59:56 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B880DB6E6 for ; Mon, 12 Dec 2022 10:59:55 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4faj-0007Nb-7D; Mon, 12 Dec 2022 04:59:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fah-0007Hl-3Q for emacs-orgmode@gnu.org; Mon, 12 Dec 2022 04:59:19 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fae-0004Iz-UD for emacs-orgmode@gnu.org; Mon, 12 Dec 2022 04:59:18 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 89EED240028 for ; Mon, 12 Dec 2022 10:59:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1670839154; bh=HuUVg0AdXmHw5d3Vz7iHBKpcrPUez+nllTL52AFSFRk=; h=From:To:Cc:Subject:Date:From; b=CUY7PPeG7GmKwe4wbpWAWGPyq14s/MLiBXTwztB6Qz2F+r8YBnIJ2dV1ZdKBEIa0B cPkUXuQZHOd4Eit5Ig719bXX4FiT5qBHPqqoE0dlniIqNuS9eFR4KalrWd+HdgOn5j ezVoiw4g86BmYVIldoXa1kV1IdX3XhgFHxBv6Iq3QVen9pfK0qVmTHCnylxzQNapEJ sAC9rwFvkIWVpU7QD0r67Si1zi1uxXyvhoj/sD9ba5B1+jlmXUw+M7xKtw0EOX69OJ YsprMxscBnbKAX1r+7XF9ior+y+rR6dWezEqEwLIKuH7SfPYRC3AOAiMu5TTT08wBl 5cJ1OcovQUY2Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NVxt84F66z9rxV; Mon, 12 Dec 2022 10:59:12 +0100 (CET) From: Ihor Radchenko To: Mark Kerr Cc: emacs-orgmode@gnu.org Subject: Re: org-agenda-dim-blocked-tasks don't use org-todo face In-Reply-To: References: Date: Mon, 12 Dec 2022 09:59:11 +0000 Message-ID: <87a63thrio.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670839195; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=c6vlSUsQlCZhPr5XDUmu3oYi5IsSPRAy9AVkJleAT1A=; b=adB1zenk6O1Pc7ZgfqzXXAcH3H3iyZC+uSKrCHq5m2tvKZDecgqDPjCDnmPdC+oIMiLfyN BD3RLCFSQvtQCvcMmmac/u4g7DC1Ewd6B2kHzL6Qs/oDmIz2+Lc1RCNgVSuVC2bGixzg3I JrK8/AQAIsfy1wZccz5GPn/j+JaIbzwr+NrsiJ1COwAUU60PLFRWY/uwReBv9B5YvT9l5g y9ht+uF39e1rIMnJLzUP0UT3NPP33U5z+t7EYlobVdc7LjTkYVzOYWoI3Q0JFxI+TJJQaN VvNC7VQwn1rsRLNohs6tkVPtHHKlTzY8BBOB7m+YzaHTscpsi23W7x2ikspNKw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=CUY7PPeG; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670839195; a=rsa-sha256; cv=none; b=J7W+ypXrMbN/VBbNCtScygXyLbwyo5vXPKaziYbBplAWX2HvTmadF43hSuRH3hJJ8CX37B phzycfgTMhyrrq5Ool1pgT/aTIEmvgofnMe8IQ4Jvj6Gab3Qd6Ug0egjrBndBtuq1Pobmk VK/PPtbqoSZabZN9L7JW/4cvm9vpVfKfN8jLKLQRpAsbz080AXXwsFYhLhozFCSzpn2OWb lKDh2kKstxs8pghVkyYOTKysSFh5+SngawR2YQIOlrHwKDmh1Enbn2QoR03jjtfH6nl33Y SklXue0wUVZSdG/oL0hVPuQ90kX7O6w8g+PYIyg06ZGxl67qhdMpDtuxuh1LhA== X-Migadu-Spam-Score: -5.75 X-Spam-Score: -5.75 X-Migadu-Queue-Id: B880DB6E6 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=CUY7PPeG; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: N/K4TzcqCtVR --=-=-= Content-Type: text/plain Mark Kerr writes: > The org-todo face is used for todo keywords in non-blocked items. > > When org-agenda-dim-blocked-tasks is set to true, however, the todo keyword > is instead displayed using org-agenda-dimmed-todo-face. > > The org-priority face, however, is still used for blocked tasks. > > Is this by design or due to an error on my part? Is there a possible > workaround? This appears to be an omission on Org part, related some overlay implementation details in Emacs. Can you try the attached patch? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-org-agenda-dim-blocked-tasks-Prioritize-face-over-ot.patch >From 1bd6d8bd13deb9e7f57826ea492bbc88fddf5ee3 Mon Sep 17 00:00:00 2001 Message-Id: <1bd6d8bd13deb9e7f57826ea492bbc88fddf5ee3.1670839095.git.yantar92@posteo.net> From: Ihor Radchenko Date: Mon, 12 Dec 2022 12:56:11 +0300 Subject: [PATCH] org-agenda-dim-blocked-tasks: Prioritize face over other overlays * lisp/org-agenda.el (org-agenda-dim-blocked-tasks): Use high overlays priority when adding dimmed face. Otherwise, contained overlays, like created by `org-agenda-fontify-priorities', will take priority (default Emacs behavior). Reported-by: Mark Kerr Link: https://orgmode.org/list/CAM9qJ5+C3nvbNaJyq6ofRgPsuAMcaBD=2UN-n96Kb68NBbX3Dg@mail.gmail.com --- lisp/org-agenda.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index eda248938..05f2e3669 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -4166,7 +4166,9 @@ (defun org-agenda-dim-blocked-tasks (&optional _invisible) (line-beginning-position)) (line-end-position)))) (when todo-blocked - (overlay-put ov 'face 'org-agenda-dimmed-todo-face)) + (overlay-put ov 'face 'org-agenda-dimmed-todo-face) + ;; Override other overlays. + (overlay-put ov 'priority 50)) (when invisible (org-agenda-filter-hide-line 'todo-blocked))) (if (= (point-max) (line-end-position)) -- 2.38.1 --=-=-= Content-Type: text/plain -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at --=-=-=--