From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EKt8O0xzX2Qc9QAASxT56A (envelope-from ) for ; Sat, 13 May 2023 13:23:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sAJxO0xzX2TyEAEAauVa8A (envelope-from ) for ; Sat, 13 May 2023 13:23:56 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6583A2EB4A for ; Sat, 13 May 2023 13:23:56 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxnLA-0007uk-Qc; Sat, 13 May 2023 07:23:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxnL8-0007rC-W4 for emacs-orgmode@gnu.org; Sat, 13 May 2023 07:23:07 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxnL6-0004hR-JK for emacs-orgmode@gnu.org; Sat, 13 May 2023 07:23:06 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 82F08240113 for ; Sat, 13 May 2023 13:23:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683976981; bh=wPoTQyf79tpaURCX3p8KAQgDlvP7PZWkRdCrHb18+oU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=c1VnJFNYAK03tGraIDF6L5EpKD+5p3ovYZICXtl8WSKaw4Il4as3+qr+oDiOrLh1Y YfBYchn3l+K54GvnJzCuIskio0Cjh8AwnJVvbCF6QcgqLQ/aNlh6zP4XA+peGnREsv RmFKNPuocG1FkJrS8zTPt6jq4rwq3dZTpeNOhkoJb6c033+snohdkJOJ2uL1ViAIDu 0z6lRxQQztC/9w517yoIe/3CGEk6c+gfyzRSP3X2xBn06IQON+0XMRZev3706llvCn fM0uh0vBqfl02TopR9FAVLRckgLEWjtj3ufMleIGfD9lIovacggmApgnNXI0GjOXvS +Pq4iqDKXw/rg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QJNXj0TLcz9rxD; Sat, 13 May 2023 13:23:01 +0200 (CEST) From: Ihor Radchenko To: stardiviner Cc: Org-mode Subject: Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist` In-Reply-To: References: <878rds1xta.fsf@localhost> Date: Sat, 13 May 2023 11:26:27 +0000 Message-ID: <87a5y8iiak.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683977036; a=rsa-sha256; cv=none; b=ZT/pNu4OvpTGBVOxzYvQG2qYTNBL8Hb3jWDDtVsfgF7H6Iz6WUaNwLktxqqADGclMoD+Bo t5i0m5RDKukPl2hcAekIw1qP9PrHtohpsh0uVeE8mqc1k8xWfreYu3kwP4HoT3lHCw2bxU XTwkphl3tOoAvNnxAe8jxjZp3PwlweOu9hZA8c3546hZqEHkj/BUp1MV/77U9SqYt1zaRR /iPUn99d146XY6NDCeqEq3zcYBJkBBBjj055JwHhRP4NfLgVU+3aqwazREPZdFSf8erGrA xYP9nD+hVxFV3h7pkv2CGNnC42ByaMqYrf4WfHYnBQh8NH2TS80MKIlLQLjt4A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=c1VnJFNY; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683977036; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AwX/sxJGW3Rg1GBcqNce6dFNB5z/6skiGnWPTMmtT8c=; b=bGgO6XYu4WOQpbj7Mavxsxer6Zz3iiqQeu7BMLMXK+9fpB1SPNpZEamooW7sr0zA2gZ2Bg hIsZ22H8cUKfYGUqQPDJMC5l9KX1Pw4dLHqo2jnGPSzlgYcAyM6vltcBtE92pRTC8d5N3P cb9kv034UG7LISXR0jlIbV/DKvDeN+2H+h0c2NnhHmx2v+sZNwa7DzD4rHw5mN7pkpC6ik hM0jea6yK2AVS7hkPRkVjvhqTDV97MzbvCQqgEyTCdBd46ufLurSnoBSDlTQzW91reaDYf xKe36/+catdUq43gdEumlizUrKy4d3lgYE88kzb+t7e0kE0w7i8SFJqIaltVFg== X-Migadu-Spam-Score: -6.39 X-Spam-Score: -6.39 X-Migadu-Queue-Id: 6583A2EB4A X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=c1VnJFNY; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: qtWST5QdGe4A stardiviner writes: > I applied your diff with a testing. This indeed solved the performance > issue. > Will this be updated in Org-mode source code? > Also I come up with one thing, filter out tags which have shortcut > keybinding bound. Because user defined shortcut key defined tags are not > always on head of list. It would be great if you can come up with a patch. 1. Keeping tags with explicitly assigned key binding indeed makes sense 2. If we limit the number of displayed tags (on top of explicitly assigned), it should be a defcustom. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at