From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MOYBFQR3v2TGugAASxT56A (envelope-from ) for ; Tue, 25 Jul 2023 09:17:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uFciFAR3v2Tc6wAAG6o9tA (envelope-from ) for ; Tue, 25 Jul 2023 09:17:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0AE543D721 for ; Tue, 25 Jul 2023 09:17:24 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=DtH8Y2Bg; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690269444; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TlqqN5WUPszEkD8ojZri3Y4k4Za285PVKioQtX2W7Xw=; b=VorzT7MgUhC0Wosz7JuoNKYX4Alax4N+sHjKPzDJ9O0NuihSysot9fytuTQFiDjj3bTqU/ 8zPx1vTnrOSrdOxpoZcDcjwdD+ilPr/WCWwaGONYPkof/H4uPgbjYzNiRQ/zwx5YusAeEK xn9ObGA7i5R2AU+V0rMSr0s8Md/jQuu9n+BOpkEvbpYG9FcqTl9RuJpUdXK+Fm63ybqDv8 WMEApVDExgvsyCQEuOMvWK588Iey6s3ADQGtTBPLmTGZxLk3Rvk3fvugjwXHKx6u4Ihwi0 gbS7jaP4DhnQmlAktkrhBDntBI3dz9+QO0PGu5nwcL3V6bAP3ICjDZDAaRy5MA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690269444; a=rsa-sha256; cv=none; b=Y+c2bwwKPghI3NULMoDf8oScHMR05/WUkDIbgA+5PbvMbhGksItAM+jcX2C2ktiWCPRgJK /g3U0HcXukX8OKQ8Mbifmv9BWVfw7zWURXSnldwcwb2K0OoXhRtw7Iu0FSrfNQDY33RAT5 P7LKQ8jENGEvjZ2a4zijyzyflawKn5aEK3WyXm5VYDoeDYqDQ/XmdRMoI6qApomorZqNKc 1IgZwzeHU3pOsYCrPXPo2U/ElL2mkhPnq0JLJv7eS8vhkPAM7BYTmq5zIubEMRINStN34C 3PRbC/pUlc6ZpqkcOC8LUVc/KoXNTgLSKr2hmPmBduvtj9/lBOW9mPl9phKbJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=DtH8Y2Bg; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOCHg-0005PN-B5; Tue, 25 Jul 2023 03:16:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOCHO-0005KB-Bw for emacs-orgmode@gnu.org; Tue, 25 Jul 2023 03:16:31 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOCHM-0004Tt-6y for emacs-orgmode@gnu.org; Tue, 25 Jul 2023 03:16:22 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8F585240104 for ; Tue, 25 Jul 2023 09:16:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690269375; bh=ny+FKwTK19sjNti34l/jpFQS9bokOLexahklcGMycpE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=DtH8Y2BgEN+uozfVF0mkRdWrzc2+K4GNfBZMaar2DxRlm3If7mt9osjH0dPANO6Hx KvcdMUiWOLNyw2ZhkdyQJ6Li5s39Njl/9S4WrXaZw87EJ6iprYNEZMtfk0La1zT0y/ maxUaB8CgRzOwJIcCKfEBWp2K+llR4G8dKv2GAfldl4At6W4Oapz3dPLSPHPsczGjX cC6KGcZhCcj2SJx8TfH+MxruOebV2xuATGcTjxa3PGvfW4VE8Q92sNqnIh33mQGf2a UCnvv6FYt8zchGxgDvewSmVkk7OT3zn+v82TUvJ1uqGfyDAs84Unx5UPZhonuPgkiq 8OcyM3xfrsOPg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R97cG5nsLz6txn; Tue, 25 Jul 2023 09:16:14 +0200 (CEST) From: Ihor Radchenko To: Jens Schmidt Cc: Eric Abrahamsen , emacs-orgmode@gnu.org Subject: Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)] In-Reply-To: <6aa47402-1546-272b-2859-4cfed1ea9ceb@vodafonemail.de> References: <2fa5914d-2cbf-f41f-8be6-e79e77794140@vodafonemail.de> <87y1j8rrag.fsf@localhost> <1b9fbe38-0572-7861-e433-8f26457302bb@vodafonemail.de> <6aa47402-1546-272b-2859-4cfed1ea9ceb@vodafonemail.de> Date: Tue, 25 Jul 2023 07:16:28 +0000 Message-ID: <87a5vk796b.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -8.88 X-Spam-Score: -8.88 X-Migadu-Queue-Id: 0AE543D721 X-TUID: 1w19wR81Snm+ Jens Schmidt writes: > > Ideally, it would be nice to have tests, though I have no clue how to > > approach writing them. > > I have created a somewhat minimal Gnus setup to develop and test this > patch on my development laptop, where I normally do not use Gnus. It > consists of a bunch of files and directories and a bit of configuration. > I can follow up on this if you like, but preferably in a separate > thread. That would be welcome. Thanks in advance! > >> Probably it would be enough to wrap the whole containing `let*' in a > >> (with-current-buffer gnus-summary-buffer ...). If we're already in the > >> summary buffer, no harm done. > > > > I am not sure if it is safe. > > There is > > (save-window-excursion (gnus-summary-select-article)) > > which calls (set-buffer gnus-summary-buffer) > > I agree with Ihor here and would rather go for individual wraps into > `with-current-buffer'. As I have done in my patch already, > incidentially. Ok. Then, if no further objections, I will apply the patch tomorrow. > > ol-gnus should store link for thing at point in current buffer. Ideally, > > without side effects. Everything else should be implementation detail. > > Could we agree on: ol-gnus should store Gnus links with as little effort > and side-effect as possible while providing reasonable functionality for > the common use cases. I think, again incidentially, that my patch > matches this criterion. > > What optionally could be improved, though, is error handling in these > pathological cases. But that would probably require some macro > > (ol-gnus-with-current-summary-buffer BODY) > > to have the error handling available in the separate places. Not sure > whether this is worth the effort. We haven't had many bug reports about ol-gnus in the past, so I do not have much statistics on whether getting such errors is common. I do not think that implementing error handling is worth an effort here. If killing summary buffer is already calling for trouble when using Gnus itself, Org mode handling the error will not make things much better. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at