emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Sean Devlin <spd@toadstyle.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Org-image-max-width doesn't account for org-indent-mode [9.7.8 (9.7.8-7f2ce8 @ /tmp/bug/elpa/org-9.7.8/)]
Date: Sun, 04 Aug 2024 18:40:28 +0000	[thread overview]
Message-ID: <87a5hsdtcz.fsf@localhost> (raw)
In-Reply-To: <6A2182FA-E074-4EC7-8950-DB4708F8D2AF@toadstyle.org>

Sean Devlin <spd@toadstyle.org> writes:

> I've found a case where an inline image's maximum width is computed
> incorrectly in Org 9.7.8. Here's a recipe:
>
> 1. Find an image wider than a default Emacs frame
> 2. Create an Org file with these contents (between the lines):
> ...
> (add-to-list 'load-path "/path/to/org-9.7.8/")
> (require 'org)
> (setq org-image-max-width 'window)
> (setq org-startup-indented t)
>
> 5. Open the file from step 2
> 6. C-c C-x C-v to toggle inline image display
>
> Observe that the images are cropped on the right in the amount of the
> leading indentation added by org-indent-mode. If you scroll down, you
> should see each successive image has a bit more cut off. (The first
> image is displayed correctly, since it is not under a heading and has no
> indentation.)

Well. This is not a bug - the image width is still equal to window
width. It is just that the image is shifted right.

I assume that you expect the image width to be adjusted to indentation
(dynamically?). However, I am not sure if it is such a good idea - what
if indentation is too deep inside? Also, this width is not dynamically
adjusted - it is computed once when you trigger image display, even for
images outside the screen. Considering that org-indent is applying
indentation lazily, only for the visible parts of the buffer,
indentation for some images may simply be not known at the point when
you ask Org to display them.

So, what you probably want is some kind of new feature to compute image
widths dynamically - I will not oppose such a feature, but it does not
yet exist. Patches welcome!

Not a bug.
Canceled. (but we can continue discussion of the feature request)

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      parent reply	other threads:[~2024-08-04 18:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-26 17:52 [BUG] Org-image-max-width doesn't account for org-indent-mode [9.7.8 (9.7.8-7f2ce8 @ /tmp/bug/elpa/org-9.7.8/)] Sean Devlin
2024-07-29 19:41 ` Sean Devlin
2024-08-01 18:47 ` Martin Edström
2024-08-04 18:40 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5hsdtcz.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=spd@toadstyle.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).