From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id yN4LKmCaimfkZAAAqHPOHw:P1 (envelope-from ) for ; Fri, 17 Jan 2025 17:58:56 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id yN4LKmCaimfkZAAAqHPOHw (envelope-from ) for ; Fri, 17 Jan 2025 18:58:56 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Vg57wciB; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1737136735; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fs7bdF4h1rJvwPX5EOaOQcZ+7U4xUKQM7OXl35dcwFo=; b=a4tK17+d6LVctdwR1fZvwHxlDFLZBSU0bp9CEwOvmDCESm8sqj6oJ+wW5mIJ2Gx39PMWmK 5hhy/oRqwGQtrP8hPz0leysCbTx1e9xyy8+pQ7jQ9S9xBYmvUWWq97srbvtYqtE0UVqAGc VlLtOAe8bUGIMgQRyb0hFKKB0EGOPditEaFI8i7GgJrF3MLxST/0uMjTJE6V4iIE9j0dIE CUNXTx58eCpJgvyBk9bidpqDMX5y2obHKzNdVpl4TTdvKrEs0/gpX3ditOC8uIJDJbL+3F tje9gF1Ic/qE4BQj/dqviXBXzmomxs7azGefsYG/6dKVKXchYjdreJv1UrKD5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Vg57wciB; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1737136735; a=rsa-sha256; cv=none; b=VCuYvcmYMwGK04V1tx3Gn3XUCnkuQH0i/ItAMX/TCn5yXLCTvSn45yP3ERdMwJo72Aw2RB jfEUfMjajLs0aG2itmvEf0g7sjM97L7qunXLimfDJpBZXNGBZ/Uwn+SvL2X+3T9wsNf2Mt EqFR8IHdR7zRykff7vyBjKA3bHLM3peSkDo9vnJo4Co7bKZEKSgF5GgkMH3YCrJNZt5xkN N7Yhj4MBFLl/fNNguxllMMBJaK1E+tMbgyw8llrAB5dysj9gRpWgiCFYv2Pj1OPd6zkW+i N9CIuOdwqSnmduGY/od3iVPuuhI9ZgNEORn6aPYlww9KeZHOhE6AfOxV/S0dOA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7F9781A54C for ; Fri, 17 Jan 2025 18:58:55 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tYqc6-0006X6-8M; Fri, 17 Jan 2025 12:58:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tYqc3-0006W5-52 for emacs-orgmode@gnu.org; Fri, 17 Jan 2025 12:58:31 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tYqc1-00047o-8U for emacs-orgmode@gnu.org; Fri, 17 Jan 2025 12:58:30 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 62B08240027 for ; Fri, 17 Jan 2025 18:58:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1737136705; bh=PG9ELnb9t6gFYxJUj7vl70VR00UzuHdQ7D3xihYXGTs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=Vg57wciBQck0+qhOZDsjbhTa/HuHZiPwC5dnQycHgTVKPyFw35UGcX4Lc85d0/pvO +WJT2LHlfPgw3FZKh4ojD1xUrf3Q5jVB6BEarNTTGca3bNmvGpEMDFKJ8Cvx1x3Pph hqREgcfnFHjal1LZ9CHYnx8emSSsUgiz645NUxaMnrzkqbEkNRvkcVOOlJBMKk3nK8 ULF7Plg+HAJhG1NYC0zFOR4OWg0d47nqp4lTVxA69O8bj9cLMWIlpJzYQJEt0gXsfC nYyk3lDjqyaA7R2jRr2a2/jblKFinlh8s2boKmzdew+sw0hxGmwQ65BUvhUWT8AaRD lqAmICoi2F2Gw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YZSC46VwWz9rxG; Fri, 17 Jan 2025 18:58:24 +0100 (CET) From: Ihor Radchenko To: Phil Estival Cc: Org Mode List Subject: Re: [PATCH] ob-sql: session In-Reply-To: References: <646f7d12-a3d1-4a7c-83e2-5eecd7ca6817@7d.nz> <87seqrh3wl.fsf@localhost> <2c80ecf8-e114-45fd-8116-49ce0f975070@7d.nz> <875xmq31vr.fsf@localhost> Date: Fri, 17 Jan 2025 18:00:42 +0000 Message-ID: <87a5bps4l1.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -3.10 X-Spam-Score: -3.10 X-Migadu-Queue-Id: 7F9781A54C X-TUID: NDXHtTzO3+A8 Phil Estival writes: > ... However, some SQL shells, like Mariadb, can only be > configured through command line parameters. These are global in Emacs > and set by `sql-set-product-feature'. So in order to support these, > the function in charge of opening the connection needs different > parameters. I could get it to run to run by setting `sql-mysql-options' > to "-s" , e.g. silent, but with an error on the prompt because > (sql-get-product-feature 'mysql :prompt-regexp) is "^mysql> ". > In conclusion, they're not exactly interchangeable even if one holds > several functions that are aliases from the other. >> Is there any specific reason why you are seemingly re-implementing what >> `sql-product-interactive' does? May we re-use it instead? >> > > Yes. When opening a new connection `sql-product-interactive' will > systematically ask for input in the mini-buffer prompt and fill the > required information, suggesting inputs from the ones previously given. > ... What about changing sql.el to provide the necessary flexibility? I'd prefer it better than rewriting parts of sql.el in Org mode. (Being a part of Emacs has advantages that we can request/submit changes upstream somewhat easier) -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at