emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: "Rudolf Adamkovič" <rudolf@adamkovic.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Improve the clock-out message
Date: Sun, 02 Feb 2025 11:34:03 +0100	[thread overview]
Message-ID: <87a5b41vqc.fsf@gmail.com> (raw)
In-Reply-To: <m2h65cpx9a.fsf@adamkovic.org> ("Rudolf Adamkovič"'s message of "Sun, 02 Feb 2025 09:27:13 +0100")

Rudolf Adamkovič <rudolf@adamkovic.org> writes:

> Rudolf Adamkovič <rudolf@adamkovic.org> writes:
>
>> * lisp/org-clock.el (org-clock-kill-emacs-query): Reword the "Clock
>> out and save?" message to "Clock out before saving?" to convey the
>> important fact that no data will be lost when answered "no".
>
> I forgot to prefix the commit title with the package name.
>
> See the attached v2.
>
> P.S. This message has been making me confused ever since I started using
> Org, and it still makes me pause and think today, hence the patch.

Seconded, thanks for taking the time to tweak this!  I sometime clock in
to some task that may require restarting Emacs (or the DE session, or
the computer); the message no longer gives me pause but it would be good
to spare future users.

One question: should it be "before saving" or "before exiting"?

* My usage pattern is "clock in; save; exit", so the buffer is already
saved;
* also, if I'm reading save-buffers-kill-emacs right, the
-query-functions are run _after_ the save prompts?


      reply	other threads:[~2025-02-02 10:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-02  8:21 [PATCH] Improve the clock-out message Rudolf Adamkovič
2025-02-02  8:27 ` Rudolf Adamkovič
2025-02-02 10:34   ` Kévin Le Gouguec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5b41vqc.fsf@gmail.com \
    --to=kevin.legouguec@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=rudolf@adamkovic.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).