From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Seltenreich Subject: Re: 23.0.94; [PATCH] org-store-link broken within kbd macros Date: Wed, 24 Jun 2009 14:39:10 +0200 Message-ID: <878wjhbyc1.fsf@gate450.dyndns.org> References: <87bponi011.fsf@gate450.dyndns.org> <8317C86B-9281-4E9E-97C2-E0EDF6C0144B@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJRl2-0000N2-Vy for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:39:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJRky-0000Hc-JL for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:39:20 -0400 Received: from [199.232.76.173] (port=52936 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJRky-0000Gv-CX for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:39:16 -0400 Received: from smtp1.rz.uni-karlsruhe.de ([129.13.185.217]:34201) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MJRkx-0001GK-2t for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:39:15 -0400 In-Reply-To: <8317C86B-9281-4E9E-97C2-E0EDF6C0144B@gmail.com> (Carsten Dominik's message of "Wed, 24 Jun 2009 14:17:59 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org, 3597@emacsbugs.donarmstrong.com [Sorry about setting Cc instead X-Debbugs-Cc and causing the duplicate report. I set a proper Mail-Followup-To header now.] Carsten Dominik writes: > This looks to me as if it was a bug in keyboard macro execution, > which should call functions interactively. The docstring for interactive-p has the following paragraph: ,----[ C-h f interactive-p RET ] | The only known proper use of `interactive-p' is in deciding whether to | display a helpful message, or how to display it. If you're thinking | of using it for any other purpose, it is quite likely that you're | making a mistake. Think: what do you want to do when the command is | called from a keyboard macro? `---- The elisp reference states: ,----[ (info "(elisp)Distinguish Interactive") ] | -- Function: interactive-p | This function returns `t' if the containing function (the one | whose code includes the call to `interactive-p') was called in | direct response to user input. This means that it was called with | the function `call-interactively', and that a keyboard macro is | not running, and that Emacs is not running in batch mode. `---- This sounds like interactive-p is working as documented and the excplicit check I proposed would be neccessary. Thanks, andreas