From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [PATCH] byte compile warnings... Date: Tue, 23 Nov 2010 23:27:06 +0100 Message-ID: <878w0jfzgl.fsf@Rainer.invalid> References: <87k4kas70y.fsf@Rainer.invalid> <878w0l14ij.wl%dmaus@ictsoc.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from [140.186.70.92] (port=46200 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PL1Kc-0003Nt-48 for emacs-orgmode@gnu.org; Tue, 23 Nov 2010 17:27:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PL1Ka-0006XS-S3 for emacs-orgmode@gnu.org; Tue, 23 Nov 2010 17:27:21 -0500 Received: from lo.gmane.org ([80.91.229.12]:42651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PL1Ka-0006Wd-Jb for emacs-orgmode@gnu.org; Tue, 23 Nov 2010 17:27:20 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PL1KY-0006Za-UJ for emacs-orgmode@gnu.org; Tue, 23 Nov 2010 23:27:18 +0100 Received: from p57aad23b.dip.t-dialin.net ([87.170.210.59]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 23 Nov 2010 23:27:18 +0100 Received: from Stromeko by p57aad23b.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 23 Nov 2010 23:27:18 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Hi David, this patch had already been partially applied by Carsten and Eric (in slightly a different way than I suggested). The changes to ob.el and ob-ref.el (the require statements) are therefore superfluous and should probably be backed out. There was also a superfluous whitespace change in org.el (a closing paren that was broken onto the next line). Patch to this effect is attached. You've already cleaned up org-agenda.el and the conditions in org-macs... --=-=-= Content-Type: Patch Content-Disposition: attachment; filename=0001-Keep-byte-compiler-happy.patch Content-Description: Cleanup >From 49e753e1e9c660c4d62fecb2b78b4abea9679026 Mon Sep 17 00:00:00 2001 From: Achim Gratz Date: Tue, 23 Nov 2010 23:18:48 +0100 Subject: [PATCH] Keep byte compiler happy * org.el: remove spurious linebreak introduced by earlier patch * ob.el, ob-ref.el: remove double fix of the same problem --- lisp/ob-ref.el | 1 - lisp/ob.el | 1 - lisp/org.el | 3 +-- 3 files changed, 1 insertions(+), 4 deletions(-) diff --git a/lisp/ob-ref.el b/lisp/ob-ref.el index a8a18ed..f350d61 100644 --- a/lisp/ob-ref.el +++ b/lisp/ob-ref.el @@ -51,7 +51,6 @@ ;;; Code: (require 'ob) (eval-when-compile - (require 'org-list) (require 'cl)) (declare-function org-remove-if-not "org" (predicate seq)) diff --git a/lisp/ob.el b/lisp/ob.el index a7ebdf9..d6e638c 100644 --- a/lisp/ob.el +++ b/lisp/ob.el @@ -30,7 +30,6 @@ ;;; Code: (eval-when-compile - (require 'org-list) (require 'cl)) (require 'org-macs) diff --git a/lisp/org.el b/lisp/org.el index 71e9428..eff4faa 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -72,8 +72,7 @@ (eval-when-compile (require 'cl) - (require 'gnus-sum) -) + (require 'gnus-sum)) (require 'calendar) (require 'pcomplete) -- 1.7.1 --=-=-= It was unwise to bundle these fixes into a single patch, I'll put them into seperate commits should the occasion arise again. Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf rackAttack: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --=-=-=--