From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Dunsmore Subject: Re: [PATCH] Preserve trailing blank lines Date: Tue, 15 Feb 2011 10:31:17 -0600 Message-ID: <878vxhgsyy.fsf@riotblast.dunsmor.com> References: <87mxngqh1o.fsf@riotblast.dunsmor.com> <078486EA-3EAD-4E6B-B428-D0DC477DFCB3@gmail.com> <87wrmchht6.fsf@riotblast.dunsmor.com> <87k4i3qg27.fsf@gnu.org> <87oc73xzu3.fsf@riotblast.dunsmor.com> <87bp2o1cos.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=35394 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PpNoA-0008Eu-W2 for emacs-orgmode@gnu.org; Tue, 15 Feb 2011 11:31:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PpNo7-0007pF-Ud for emacs-orgmode@gnu.org; Tue, 15 Feb 2011 11:31:22 -0500 Received: from deathroller.dunsmor.com ([98.129.169.48]:58861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PpNo7-0007os-N0 for emacs-orgmode@gnu.org; Tue, 15 Feb 2011 11:31:19 -0500 In-Reply-To: <87bp2o1cos.fsf@gnu.org> (Bastien's message of "Mon, 07 Feb 2011 09:17:07 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org, Carsten Dominik Bastien writes: > However, with your patch, I get a weird behavior. > > Config: > > ,---- > | (setq org-blank-before-new-entry '((heading . nil) > | (plain-list-item . nil))) > `---- > > Test file: > > ,---- > | * Section > | > | ** Subsection 1 > | Body > | > | ** Subsection 2 > | Body > `---- > > Trying to move Subsection 1 down (with org-metadown): > > ,---- > | * Section > | Body <<<<<< ?? > | > | ** Subsection 2 > | > | ** Subsection 1 > | Body > `---- > > Are you able to reproduce this? I finally had a chance to test this out with the latest Org from git and a vanilla Emacs config, and I was unable to reproduce the behavior you saw. Here is what I did: $ git clone git://orgmode.org/org-mode.git $ emacs23 -Q & (Edit org.el to re-introduce patch.) $ cd org-mode/ $ git diff diff --git a/lisp/org.el b/lisp/org.el index 164081c..4329def 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -18507,10 +18507,10 @@ Taken from `count' in cl-seq.el with all keyword argum "Move backwards over whitespace, to the beginning of the first empty line. Returns the number of empty lines passed." (let ((pos (point))) - (skip-chars-backward " \t\n\r") - ;; (if (cdr (assoc 'heading org-blank-before-new-entry)) - ;; (skip-chars-backward " \t\n\r") - ;; (forward-line -1)) + ;;(skip-chars-backward " \t\n\r") + (if (cdr (assoc 'heading org-blank-before-new-entry)) + (skip-chars-backward " \t\n\r") + (forward-line -1)) (beginning-of-line 2) (goto-char (min (point) pos)) (count-lines (point) pos))) Then I evaluated the following in Emacs: (delete "/usr/share/emacs/23.2/lisp/org/" load-path) (add-to-list 'load-path "~/tmp/org-mode/lisp") (require 'org-install) (setq org-blank-before-new-entry '((heading . nil) (plain-list-item . nil))) You can see what happened on my screen with the following: wget http://98.129.169.48/tmp/emacs-testing.time wget http://98.129.169.48/tmp/emacs-testing.script scriptreplay emacs-testing.time emacs-testing.script Would you mind testing it out again? Regards, Jason