emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Pieter Praet <pieter@praet.org>
To: Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>, emacs-orgmode@gnu.org
Subject: Re: disable "org-decrypt: auto-save-mode may cause leakage"
Date: Thu, 14 Jul 2011 17:50:30 +0200	[thread overview]
Message-ID: <878vs0zws9.fsf@praet.org> (raw)
In-Reply-To: <808vs0hqj1.fsf@somewhere.org>

On Thu, 14 Jul 2011 16:42:58 +0200, "Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> wrote:
> Hi Pieter,
> 
> Pieter Praet wrote:
> > On Thu, 14 Jul 2011 15:37:34 +0200, "Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> wrote:
> >> Juan Pechiar wrote:
> >> > On Thu, Jul 14, 2011 at 02:22:32PM +0200, Karl Voit wrote:
> >> >> How can I auto-answer the question from the subject line with «n»
> >> >> (per default) any time it is asked?
> >> >
> >> > You can customize this behaviour via
> >> >
> >> >     org-crypt-disable-auto-save
> >> >
> >> > You probably have it set to 'ask'.
> >> 
> >> So did I. This is the default.
> >> 
> >> > Options exist for always enabling/disabling auto save, and for encrypting
> >> > the auto-saved version automatically.
> >> >
> >> > M-x customize-variable RET org-crypt-disable-auto-save RET
> >> 
> >> Shouldn't its default value better be set to 'encrypt?
> >
> > I don't think so.
> >
> > It only re-encrypts entries which are tagged :crypt: (or whatever you
> > have `org-crypt-tag-matcher' set to), so I'd prefer users to be "forced"
> > to at least read the docstring so as not to be using it with a false
> > sense of security.
> >
> > Though this could be easily solved by automatically tagging entries upon
> > encryption, I think it's more "considerate" to simply (ask to) disable
> > `auto-save-mode' for the current buffer, as it's quite annoying to have
> > an entry get re-encrypted while you're in the middle of typing something.
> 
> This is more clear to me, and makes a lot of sense.
> 
> Though, what I find annoying, and the OP as well, is to be asked that question
> for buffers which do not contain any encrypted entry. Would it be possible to
> scan the buffer for such entries, and only ask the user when the buffer is
> potentially exposed?

AFAIK, that should already be the case.


Even when running with the following config...

  #+BEGIN_SRC emacs-lisp
    (add-hook 'find-file-hook 'org-decrypt-entries)
  #+END_SRC

... the user shouldn't get prompted needlessly, because `org-decrypt-entries'
applies `org-decrypt-entry' (which does the `auto-save-mode' check) *only*
to entries with a tag matching `org-crypt-tag-matcher' [1].

So prompting should only occur for buffers for which `auto-save-mode' is
enabled AND which contain one or more entries tagged with `crypt'
(regardless of whether the entry is actually encrypted, but that's
beside the point) UNLESS running `org-decrypt-entry' (auto-)manually for
each buffer.


I suspect it's a user config issue.

> Best regards,
>   Seb
> 
> -- 
> Sebastien Vauban
> 
> 


Peace

-- 
Pieter

[1] lisp/org-crypt.el:241

  reply	other threads:[~2011-07-14 15:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14 12:22 disable "org-decrypt: auto-save-mode may cause leakage" Karl Voit
2011-07-14 13:14 ` Pieter Praet
2011-07-14 13:17 ` Juan Pechiar
2011-07-14 13:37   ` Sebastien Vauban
2011-07-14 14:25     ` Pieter Praet
2011-07-14 14:42       ` Sebastien Vauban
2011-07-14 15:50         ` Pieter Praet [this message]
2011-07-18  9:24           ` Sebastien Vauban
2011-07-18 23:12             ` Bastien
2011-08-27 16:22               ` Pieter Praet
2011-08-28  7:02                 ` Achim Gratz
2011-08-28 11:35                   ` Pieter Praet
2011-08-28 13:46                     ` [PATCH] org-crypt: when running org-decrypt-entry, only run auto-save-mode check if on an encrypted entry Pieter Praet
2011-10-08 16:11                       ` Carsten Dominik
2011-10-27  8:52                         ` Pieter Praet
2011-10-28 15:13                           ` Bastien
2011-08-29  9:09                 ` disable "org-decrypt: auto-save-mode may cause leakage" Sebastien Vauban
2011-07-14 15:14   ` Karl Voit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vs0zws9.fsf@praet.org \
    --to=pieter@praet.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).