emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Bernt Hansen <bernt@norang.ca>
Cc: Julian Gehring <julian.gehring@googlemail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] org.texi: Fix missing links and formatting in 'Exporting' section
Date: Mon, 09 Apr 2012 12:35:59 +0200	[thread overview]
Message-ID: <878vi519bk.fsf@gnu.org> (raw)
In-Reply-To: <87hawus2r7.fsf@norang.ca> (Bernt Hansen's message of "Sun, 08 Apr 2012 10:43:24 -0400")

Hi Julian,

thanks for the patch, I applied an edited version of it.

Bernt Hansen <bernt@norang.ca> writes:

> Julian Gehring <julian.gehring@googlemail.com> writes:
>
>> From 40344d3dd27af520ba09516b72e6cbb06a37e780 Mon Sep 17 00:00:00 2001
>> From: Julian Gehring <julian.gehring@googlemail.com>
>> Date: Sun, 8 Apr 2012 15:24:47 +0200
>> Subject: [PATCH] org.texi: Fix missing links and formatting in 'Exporting'
>>  section
>
> Hi Julian,
>
> Why is the last hunk in this patch useful?  Doesn't it just add a
> trailing blank?
>
>> @@ -11588,7 +11587,7 @@ two table styles with the names @samp{TableWithHeaderRowAndColumn} and
>>  @samp{TableWithFirstRowandLastRow}.  (@strong{Important:} The OpenDocument
>>  styles needed for producing the above template have been pre-defined for you.
>>  These styles are available under the section marked @samp{Custom Table
>> -Template} in @file{OrgOdtContentTemplate.xml}
>> +Template} in @file{OrgOdtContentTemplate.xml} 
>>  (@pxref{x-orgodtcontenttemplate-xml,,Factory styles}).  If you need
>>  additional templates you have to define these styles yourselves.
>
> I think this hunk should probably be dropped.

I dropped it before applying the patch.

Best,

-- 
 Bastien

  reply	other threads:[~2012-04-09 10:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-08 13:27 [PATCH] org.texi: Fix missing links and formatting in 'Exporting' section Julian Gehring
2012-04-08 14:43 ` Bernt Hansen
2012-04-09 10:35   ` Bastien [this message]
2012-04-09 19:17   ` Julian Gehring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vi519bk.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=julian.gehring@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).