Re: Patch: org-agenda-skip-deadline-prewarning-if-scheduled prior to scheduled date

[Nicolas Goaziou <n.goaziou@gmail.com>]

Hello,

Justus-dev@Piater.name writes:

> But first one more request for comments that I forgot to include in my
> original message:
>
> Computing the difference between two dates in the presence of repeating
> dates is a subtle affair.  Here, in computing the difference between
> deadline (d2) and scheduled date (ds),
>
> 			(min (- d2 (org-time-string-to-absolute
> 				    ds d1 'past show-all (current-buffer) pos))
> 			     org-deadline-warning-days)
>
> I simply followed the time-to-deadline computation of the current TODO
> item from a few lines above:
>
> 	(setq ...
> 	      d2 (org-time-string-to-absolute
> 		  (match-string 1) d1 'past show-all
> 		  (current-buffer) pos)
> 	      diff (- d2 d1))
>
> I sort-of see what this org-time-string-to-absolute call does, but I do
> not fully understand its implications.  It would be good for someone who
> does to verify that my code indeed rightly follows the same logic.

The code looks good to me. If there is no objection, I think we can
apply the patch.


Regards,

-- 
Nicolas Goaziou