From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: Patch: org-agenda-skip-deadline-prewarning-if-scheduled prior to
 scheduled date
Date: Sun, 28 Oct 2012 11:20:15 +0100
Message-ID: <878vaqsxsw.fsf@gmail.com>
References: <87wqypedlk.fsf@pc130-c703.uibk.ac.at> <87zk3lmelw.fsf@gmail.com>
	<87txthh4a0.fsf@pc130-c703.uibk.ac.at>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:41670)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1TSQ1f-00036U-Ht
	for emacs-orgmode@gnu.org; Sun, 28 Oct 2012 06:23:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1TSQ1e-0004dE-Gf
	for emacs-orgmode@gnu.org; Sun, 28 Oct 2012 06:23:27 -0400
Received: from mail-we0-f169.google.com ([74.125.82.169]:38906)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1TSQ1e-0004dA-AJ
	for emacs-orgmode@gnu.org; Sun, 28 Oct 2012 06:23:26 -0400
Received: by mail-we0-f169.google.com with SMTP id u3so2352442wey.0
	for <emacs-orgmode@gnu.org>; Sun, 28 Oct 2012 03:23:25 -0700 (PDT)
In-Reply-To: <87txthh4a0.fsf@pc130-c703.uibk.ac.at> (Justus-bulk@piater.name's
	message of "Fri, 26 Oct 2012 13:16:39 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Justus-bulk@Piater.name
Cc: emacs-orgmode@gnu.org

Hello,

Justus-bulk@Piater.name writes:

> My current solution (see the patch) involves some minor refactoring at
> the price of an extra (if ds ...) that I don't see a way to get rid of,
> but I find the result quite readable.

It looks good. I would have integrated the (if ds ...) within the cond
(i.e (cond ((not ds) nil) ...)) but it doesn't matter much.

> I signed the FSF GNU EMACS copyright assignment form a few years ago.
> Do I need to do something else for org-mode?

No, it should be fine.

I've applied your patch. Thank you for your contribution.


Regards,

-- 
Nicolas Goaziou