From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Justus-bulk@Piater.name
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch: org-agenda-skip-deadline-prewarning-if-scheduled prior to scheduled date
Date: Sun, 28 Oct 2012 11:20:15 +0100 [thread overview]
Message-ID: <878vaqsxsw.fsf@gmail.com> (raw)
In-Reply-To: <87txthh4a0.fsf@pc130-c703.uibk.ac.at> (Justus-bulk@piater.name's message of "Fri, 26 Oct 2012 13:16:39 +0200")
Hello,
Justus-bulk@Piater.name writes:
> My current solution (see the patch) involves some minor refactoring at
> the price of an extra (if ds ...) that I don't see a way to get rid of,
> but I find the result quite readable.
It looks good. I would have integrated the (if ds ...) within the cond
(i.e (cond ((not ds) nil) ...)) but it doesn't matter much.
> I signed the FSF GNU EMACS copyright assignment form a few years ago.
> Do I need to do something else for org-mode?
No, it should be fine.
I've applied your patch. Thank you for your contribution.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2012-10-28 10:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 7:56 Patch: org-agenda-skip-deadline-prewarning-if-scheduled prior to scheduled date Justus-dev
2012-10-17 13:07 ` Nicolas Goaziou
2012-10-17 14:29 ` Justus-dev
2012-10-25 13:36 ` Nicolas Goaziou
2012-10-26 11:16 ` Justus-bulk
2012-10-28 10:20 ` Nicolas Goaziou [this message]
2012-10-28 12:27 ` Justus-bulk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vaqsxsw.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=Justus-bulk@Piater.name \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).