emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [RFC] Change some defcustoms into defcont
@ 2013-10-20  8:47 Nicolas Goaziou
  2013-10-20 18:23 ` Carsten Dominik
  2013-10-21  8:17 ` Sebastien Vauban
  0 siblings, 2 replies; 19+ messages in thread
From: Nicolas Goaziou @ 2013-10-20  8:47 UTC (permalink / raw)
  To: Org Mode List

Hello,

I'd like to suggest changing the following defcustom variables into
defconst:

  - org-deadline-string
  - org-scheduled-string
  - org-closed-string
  - org-clock-string
  - org-comment-string
  - org-quote-string
  - org-effort-property
  - org-archive-tag

There's no fundamental reason to change these, as they belong to Org
syntax, much like star character for headlines and ":END:" closing
string for drawers.

They can also introduce bugs in code when modified (e.g. modifying
`org-effort-property' breaks `ox-taskjuggler'). Of course, this can be
avoided with careful checks, but this puts an extra burden on developers
for a tiny benefit for the user.

Eventually, they can be costly, since changing any of them implies that
cache in every Org buffer must be erased.

Allowing customization is generally good, but I think Org syntax should
never be a moving target.

Note that this shouldn't introduce much backward incompatibility (unless
user changes them through customize interface) since a defconst can
still be setq'ed and variables will still be used in code base.

Opinions?


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2013-11-16 23:55 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-20  8:47 [RFC] Change some defcustoms into defcont Nicolas Goaziou
2013-10-20 18:23 ` Carsten Dominik
2013-10-21  8:56   ` Nicolas Goaziou
2013-10-21 10:26     ` Carsten Dominik
2013-10-21 10:51       ` Nicolas Goaziou
2013-10-21 11:56         ` Carsten Dominik
2013-10-21 15:15           ` Nicolas Goaziou
2013-10-22  7:50             ` Carsten Dominik
2013-10-22  9:52               ` Nicolas Goaziou
2013-10-22 10:34                 ` Carsten Dominik
2013-10-22 18:28                   ` Torsten Wagner
2013-10-22 20:00                     ` Florian Beck
2013-10-23  8:56                   ` Nicolas Goaziou
2013-10-23 13:25                     ` Carsten Dominik
2013-10-29 14:04                       ` Nicolas Goaziou
2013-10-29 14:11                         ` Nicolas Goaziou
2013-11-16 20:25                       ` Nicolas Goaziou
2013-11-16 23:55                         ` Carsten Dominik
2013-10-21  8:17 ` Sebastien Vauban

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).