From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Subject: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not
 display current-buffer." when composing a message
Date: Wed, 11 Jun 2014 21:11:37 +0200
Message-ID: <878up3tg5y.fsf__28180.6670515381$1402513959$gmane$org@yahoo.fr>
References: <m2ha3tdrt6.fsf@gmail.com> <837g4o1x3r.fsf@gnu.org>
	<CALMze+rsDUB3seBY2LvbmSuSJouh4C4Avez9uwQWreriDgtFOw@mail.gmail.com>
	<87r42vlavi.fsf@geodiff-mac3.ulb.ac.be> <87ha3rxx79.fsf@bzg.ath.cx>
	<87zjhjxwaf.fsf@geodiff-mac3.ulb.ac.be> <878up3xvje.fsf@bzg.ath.cx>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50106)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WunwN-00050z-OV
	for emacs-orgmode@gnu.org; Wed, 11 Jun 2014 15:12:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WunwI-000599-Gu
	for emacs-orgmode@gnu.org; Wed, 11 Jun 2014 15:12:07 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.17746.B17746.1402513908595@debbugs.gnu.org>
In-Reply-To: <878up3xvje.fsf@bzg.ath.cx> (Bastien's message of "Wed, 11 Jun
	2014 18:25:57 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien <bzg@altern.org>
Cc: Nicolas Richard <theonewiththeevillook@yahoo.fr>, 17746@debbugs.gnu.org, David Griffiths <dogriffiths@gmail.com>

Bastien <bzg@altern.org> writes:

> Nicolas Richard <theonewiththeevillook@yahoo.fr> writes:
>
>> Bastien <bzg@altern.org> writes:
>>> PS: The change about throwing an error when recentering a window
>>> that does not display the current buffer breaks ~37 tests in Org
>>> master branch, even with this fix.  I need to digg this further.
>>
>> For me, fixing also org-fix-ellipsis-at-bol made all tests run as
>> expected.
>
> What do you mean by "fixing"?  Removing it entirely?

Yes, I admit, I did : (defsubst org-fix-ellipsis-at-bol () nil)
But I must have done something wrong or misread the results because now
I see some other failures. Moreover, the backtrace that I get from "make
test" seems incomplete and it's not obvious to me where the recenter
call is made.

OTOH I hope that wrapping every call to recenter in a
(when (eq (current-buffer) (window-buffer))
   (recenter ...))
would fix the tests, no ?

-- 
Nico.