From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: patch: Oracle engine for SQL blocks Date: Fri, 13 Jun 2014 07:44:56 -0400 Message-ID: <878up1dnom.fsf@gmail.com> References: <1402463432.31873.127469781.7224901D@webmail.messagingengine.com> <877g4lx4t7.fsf@gmail.com> <1402632199.9139.128293873.498FDE9C@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvQAS-0001bQ-SM for emacs-orgmode@gnu.org; Fri, 13 Jun 2014 08:01:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvQAM-0002BJ-R8 for emacs-orgmode@gnu.org; Fri, 13 Jun 2014 08:01:12 -0400 Received: from mail-oa0-x22c.google.com ([2607:f8b0:4003:c02::22c]:48085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvQAM-0002BC-Mu for emacs-orgmode@gnu.org; Fri, 13 Jun 2014 08:01:06 -0400 Received: by mail-oa0-f44.google.com with SMTP id i7so2752027oag.17 for ; Fri, 13 Jun 2014 05:01:06 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: John Dell'Aquila Cc: emacs-orgmode@gnu.org "John Dell'Aquila" writes: > Thanks, Eric. I've started the FSF assignment process. > > I have a question about the header row delimiter in the results table. I > didn't set the header-delim variable in the code, becasue the user can > change the Oracle underline character, possibly multiple times, so it is > difficult to work out a proper setting. > > The results appeared OK with header-delim left at "". I now realize that > this causes the table to be mis-parsed when the first column is blank, > even though it has a proper header. > > I put in a fix to scan for the first "set underline" command and use > that character, otherwise set header-delim to "-". In the process of > testing I found I could always set header-delim to '-' and the table > parsed correctly even when the actual Oracle delimiter was set > differently. > > I'm wondering how this is supposed to work. I'd rather not add > unecessary complexity, but I don't want on rely on a bug or misfeature > either. > I'm not familiar with this portion of ob-sql, so I'll defer to your best judgment. Best, -- Eric Schulte https://cs.unm.edu/~eschulte PGP: 0x614CA05D (see https://u.fsf.org/yw)