From: Eric Schulte <schulte.eric@gmail.com>
To: John Dell'Aquila <dellaq@ml1.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: patch: Oracle engine for SQL blocks
Date: Fri, 13 Jun 2014 07:44:56 -0400 [thread overview]
Message-ID: <878up1dnom.fsf@gmail.com> (raw)
In-Reply-To: 1402632199.9139.128293873.498FDE9C@webmail.messagingengine.com
"John Dell'Aquila" <dellaq@ml1.net> writes:
> Thanks, Eric. I've started the FSF assignment process.
>
> I have a question about the header row delimiter in the results table. I
> didn't set the header-delim variable in the code, becasue the user can
> change the Oracle underline character, possibly multiple times, so it is
> difficult to work out a proper setting.
>
> The results appeared OK with header-delim left at "". I now realize that
> this causes the table to be mis-parsed when the first column is blank,
> even though it has a proper header.
>
> I put in a fix to scan for the first "set underline" command and use
> that character, otherwise set header-delim to "-". In the process of
> testing I found I could always set header-delim to '-' and the table
> parsed correctly even when the actual Oracle delimiter was set
> differently.
>
> I'm wondering how this is supposed to work. I'd rather not add
> unecessary complexity, but I don't want on rely on a bug or misfeature
> either.
>
I'm not familiar with this portion of ob-sql, so I'll defer to your best
judgment.
Best,
--
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D (see https://u.fsf.org/yw)
prev parent reply other threads:[~2014-06-13 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 5:10 patch: Oracle engine for SQL blocks John Dell'Aquila
2014-06-12 20:00 ` Eric Schulte
[not found] ` <1402632199.9139.128293873.498FDE9C@webmail.messagingengine.com>
2014-06-13 11:44 ` Eric Schulte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878up1dnom.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=dellaq@ml1.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).