From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions starting and ending a line Date: Thu, 28 Aug 2014 12:10:51 +0200 Message-ID: <878um8gc0k.fsf@nicolasgoaziou.fr> References: <87mwbbp45b.fsf@nicolasgoaziou.fr> <87ppg6bvzd.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMwel-0004un-Rc for emacs-orgmode@gnu.org; Thu, 28 Aug 2014 06:10:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMwee-0001bB-1L for emacs-orgmode@gnu.org; Thu, 28 Aug 2014 06:10:15 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:46938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMwed-0001W4-SL for emacs-orgmode@gnu.org; Thu, 28 Aug 2014 06:10:07 -0400 In-Reply-To: (Federico Beffa's message of "Sat, 16 Aug 2014 09:38:29 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Federico Beffa Cc: emacs-orgmode@gnu.org, Rasmus Hello, Federico Beffa writes: > In any case, I've updated my git repository (less than 24h ago) and > recreated the patch. I've tested it and believe it is working. Why > don't you give it a try. It's not such a disruptive change. I looked at the patch. You are still applying it on maint, while the function in /master/ branch is different. If you look at it, you will see there are simple ways to achieve what you want (i.e no need for 3 helper functions and 80 additional locs). Also, I think your implementation is still ill-defined. Consider the following case: Paragraph with a very very ... long line \[some math\] IIUC, M-q should fill the math snippet since it doesn't start nor end lines. However, if I add text, e.g. additional "very" in the first line, auto-filling will eventually move "\[some" to the next line, leading to Paragraph with a very very very very ... long line \[some math\] which cannot be filled since, this time, "\[" starts a line and "\]" ends one. This math snippet is at the same time fillable and un-fillable. Schr=C3=B6dinger's snippet. IOW, you also need to prevent "\[some" to be moved to a new line on its own. Regards, --=20 Nicolas Goaziou