From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check
Date: Thu, 16 Oct 2014 22:25:10 +0200 [thread overview]
Message-ID: <878ukf3gpl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87d29rajwv.fsf@kmlap.domain.org> (Kyle Meyer's message of "Thu, 16 Oct 2014 15:34:08 -0400")
Hello,
Kyle Meyer <kyle@kyleam.com> writes:
> A question on Stack Overflow [1] reported an issue overriding
> `org-clock-into-drawer' with properties (specifically, overriding a
> global value of t with a property value nil). Looking into the function
> `org-clock-into-drawer', the actual behavior did not match the
> documented behavior. The attached patch should fix the issue.
Thanks for the patch.
> - (let ((p (org-entry-get nil "CLOCK_INTO_DRAWER" 'inherit))
> - (q (org-entry-get nil "LOG_INTO_DRAWER" 'inherit)))
> + (let ((p (org-entry-get nil "CLOCK_INTO_DRAWER" 'inherit t))
> + (q (org-entry-get nil "LOG_INTO_DRAWER" 'inherit t)))
> (cond
> - ((or (not (or p q)) (equal p "nil") (equal q "nil")) org-clock-into-drawer)
> - ((or (equal p "t") (equal q "t")) "LOGBOOK")
> - ((not p) q)
> - (t p))))
> + ((not (or p q)) org-clock-into-drawer)
> + ((equal p "nil") nil)
> + ((equal p "t") "LOGBOOK")
> + ((equal q "nil") nil)
> + ((equal q "t") "LOGBOOK"))))
This is wrong.
If p is a string, e.g. "FOO", return value should be "FOO". Ditto if
q contains a string.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2014-10-16 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 19:34 [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check Kyle Meyer
2014-10-16 20:25 ` Nicolas Goaziou [this message]
2014-10-16 20:39 ` Kyle Meyer
2014-10-16 20:51 ` Kyle Meyer
2014-10-16 21:01 ` Nicolas Goaziou
2014-10-16 21:20 ` Kyle Meyer
2014-10-16 22:21 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ukf3gpl.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).