From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] fix for ignored header args in org-babel-tangle
Date: Thu, 23 Apr 2015 21:55:01 +0200
Message-ID: <878udi1uy2.fsf@nicolasgoaziou.fr>
References: <5532F914.5020505@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50741)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YlNBt-0006Oa-9Y
	for emacs-orgmode@gnu.org; Thu, 23 Apr 2015 15:53:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YlNBr-0000Xo-RD
	for emacs-orgmode@gnu.org; Thu, 23 Apr 2015 15:53:41 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:53172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YlNBr-0000Xf-Kx
	for emacs-orgmode@gnu.org; Thu, 23 Apr 2015 15:53:39 -0400
In-Reply-To: <5532F914.5020505@gmail.com> (Sam Ritchie's message of "Sat, 18
	Apr 2015 18:38:44 -0600")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Sam Ritchie <sritchie09@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Sam Ritchie <sritchie09@gmail.com> writes:

> I found that all of my header arguments to source blocks were getting
> ignored. Moving the header-args into the let* binding seems to fix
> this issue, though I'm not enough of a guru to know why. Without this
> arguments like
>
> #+BEGIN_SRC clojure :tangle ./project.clj
>
> and
>
> #+BEGIN_SRC clojure :tangle no
>
> were getting ignored and substituted for ":tangle yes" along with
> other defaults.
>
> Hope this patch is in the right format:

Thank you. 

Would you mind providing your patch with "git format-patch" and follow
guidelines at

  http://orgmode.org/worg/org-contribute.html

for the commit message (e.g., you need to add TINYCHANGE at its end if
you didn't sign FSF papers yet).

Eventually, could you write a test for this? See
"testing/lisp/test-ob-tangle.el".


Regards,

-- 
Nicolas Goaziou