From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Daniel P Gomez <gomez.danp@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Have SRC_BLOCK :padline accept numbers
Date: Wed, 29 Mar 2017 14:27:00 +0200 [thread overview]
Message-ID: <878tnoqne3.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAJTMgxg0+bub2OzaKhUVN32O3iLWe44OkyS1P0nb-4H8z-PT=w@mail.gmail.com> (Daniel P. Gomez's message of "Tue, 28 Mar 2017 21:47:42 +0200")
Hello,
Daniel P Gomez <gomez.danp@gmail.com> writes:
> I've written a small patch (attached here), following the contribution
> guidelines on the org-mode website. The "patched" repository can be found
> here: https://github.com/dangom/org-mode/tree/feature_padline
Thank you.
> Please let me know if there is anything else I should do.
Some comments follow.
> From f5e67856b6cefb7c5e9c1b6bd74321d3b47f1b05 Mon Sep 17 00:00:00 2001
> From: Daniel Gomez <d.gomez@posteo.org>
> Date: Tue, 28 Mar 2017 21:20:23 +0200
> Subject: [PATCH] Add support for :padline with numbers in ob-tangle.
>
You need to add list modified functions here, with the actual
modifiaction, e.g.,
* lisp/ob-tangle.el (the-function-I-modified): Been there, done that.
Also, if you haven't signed FSF papers yet, you need to add "TINYCHANGE"
at the end of the commit message.
> - (unless (or (string= "no" (cdr (assq :padline (nth 4 spec))))
> - (= (point) (point-min)))
> - (insert "\n"))
> + (let ((padlines (format "%s" (cdr (assq :padline (nth 4 spec))))))
> + (cond
> + ((and (string= "nil" padlines) (not (= (point) (point-min))))
(not (= (point) (point-min))) -> (not (bobp))
> + (insert "\n"))
> + ((string= "no" padlines)
> + nil)
> + ((numberp (string-to-int padlines))
(numberp (string-to-int padlines)) -> (string-match-p "\\`[0-9]+\\'" padlines)
> + (dotimes (i (string-to-int padlines)) (insert "\n")))
string-to-int -> string-to-number
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-03-29 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 19:47 Have SRC_BLOCK :padline accept numbers Daniel P Gomez
2017-03-29 12:27 ` Nicolas Goaziou [this message]
2017-03-29 16:03 ` Daniel P Gomez
2017-03-30 7:50 ` Nicolas Goaziou
2017-04-18 8:37 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tnoqne3.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=gomez.danp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).