Fix for ob-sqlite tests

Fix for ob-sqlite tests

[Robert Klein]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

Hi,

the tests for sqlite don't work because

1. the executable is sqlite3, not sqlite anymore for current software
(and obsqlite uses “sqlite3”, too)

2. the test doesn't have ob-sqlite loaded.


Please advice, if the “(require 'obsqlite)” is offensive.


Patch is attached.



Best regards
Robert

[-- Attachment #2: 0001-Fix-tests-for-sqlite.patch --]
[-- Type: text/x-patch, Size: 861 bytes --]

From c48a90b94bc7f0a86c7dd3b4747c893e64ec2e31 Mon Sep 17 00:00:00 2001
From: Robert Klein <roklein@roklein.de>
Date: Sun, 9 Sep 2018 14:27:20 +0200
Subject: [PATCH] Fix tests for sqlite

- sqlite executable used by ob-sqlite is 'sqlite3'
- require ob-sqlite for test
---
 testing/lisp/test-ob-sqlite.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testing/lisp/test-ob-sqlite.el b/testing/lisp/test-ob-sqlite.el
index f73251534..0cf68fabc 100644
--- a/testing/lisp/test-ob-sqlite.el
+++ b/testing/lisp/test-ob-sqlite.el
@@ -19,7 +19,8 @@
 ;; along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 ;;; Code:
-(org-test-for-executable "sqlite")
+(org-test-for-executable "sqlite3")
+(require 'ob-sqlite)
 (unless (featurep 'ob-sqlite)
   (signal 'missing-test-dependency "Support for sqlite code blocks"))
 
-- 
2.16.2

Re: Fix for ob-sqlite tests

[Nicolas Goaziou]

Hello,

Robert Klein <roklein@roklein.de> writes:

> the tests for sqlite don't work because
>
> 1. the executable is sqlite3, not sqlite anymore for current software
> (and obsqlite uses “sqlite3”, too)
>
> 2. the test doesn't have ob-sqlite loaded.
>
> Please advice, if the “(require 'obsqlite)” is offensive.
>
>
> Patch is attached.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou