From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Suggested patch for org-agenda.el
Date: Wed, 08 May 2019 14:43:47 +0200
Message-ID: <878svhdsl8.fsf@nicolasgoaziou.fr>
References: <jwvwoj3gphq.fsf-monnier+emacs@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:54204)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1hOLvP-0006az-6h
	for emacs-orgmode@gnu.org; Wed, 08 May 2019 08:43:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1hOLvO-0008AF-B9
	for emacs-orgmode@gnu.org; Wed, 08 May 2019 08:43:55 -0400
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:36845)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1hOLvO-00088R-39
	for emacs-orgmode@gnu.org; Wed, 08 May 2019 08:43:54 -0400
In-Reply-To: <jwvwoj3gphq.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message
	of "Mon, 06 May 2019 19:07:39 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-orgmode@gnu.org

Hello,

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> Misc changes:

Thank you.

> - Assume Emacs=E2=89=A522 (we're using defvaralias already anyway).
> - Try to make sure <foo>-function only contain functions (and never nil).
> - Use define-minor-mode and define-derived-mode.
> - Use command remapping.
> - Initialize map from within its definition.
> - Use suppress-keymap.
>
> There'd be more to do if we can assume =E2=89=A524.1, of course.

Starting from 9.0, Org assumes =E2=89=A524.4, so we can go wild, if necessa=
ry.

However, I cannot apply your patch on top of master branch. Would you
mind building your patch from Org repository?

Regards,

--=20
Nicolas Goaziou