emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-orgmode@gnu.org
Subject: Re: Suggested patch for org-agenda.el
Date: Wed, 08 May 2019 14:43:47 +0200	[thread overview]
Message-ID: <878svhdsl8.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <jwvwoj3gphq.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 06 May 2019 19:07:39 -0400")

Hello,

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> Misc changes:

Thank you.

> - Assume Emacs≥22 (we're using defvaralias already anyway).
> - Try to make sure <foo>-function only contain functions (and never nil).
> - Use define-minor-mode and define-derived-mode.
> - Use command remapping.
> - Initialize map from within its definition.
> - Use suppress-keymap.
>
> There'd be more to do if we can assume ≥24.1, of course.

Starting from 9.0, Org assumes ≥24.4, so we can go wild, if necessary.

However, I cannot apply your patch on top of master branch. Would you
mind building your patch from Org repository?

Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2019-05-08 12:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06 23:07 Suggested patch for org-agenda.el Stefan Monnier
2019-05-08 12:43 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878svhdsl8.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).