Bug and quick bugfix

Bug and quick bugfix

[Godefroy]

Hello,

As it is my first email to the list, please forgive me if I do anything
the wrong way.

I recently encountered a bug when exporting an org file to LaTeX: when
generating a figure with a caption, the LaTeX result has the following
shape:

\begin{figure}
…
\caption{\label{…}
Content of the caption}
\end{figure}

When compiling to LaTeX, the carriage return causes a indesirable white
space in some cases. What I would expect is:

\begin{figure}
…
\caption{Content of the caption}
\label{…}
\end{figure}

To fix this, I have changed the org-latex--caption/label-string function
in ox-latex.el on lines 1314 and 1315:

(format (if nonfloat "\\captionof{%s}%s{%s%s}\n"
 "\\caption%s%s{%s%s}\n")

becomes

(format (if nonfloat "\\captionof{%s}%s{%s}\n%s"
 "\\caption%s%s{%s}\n%s")

I hope that this bug report and the quickfix I found will help you.

Sincerely,

Godefroy Vannoye

Re: Bug and quick bugfix

[Nicolas Goaziou]

Hello,

Godefroy <godefroy.vannoye@gmail.com> writes:

> I recently encountered a bug when exporting an org file to LaTeX: when
> generating a figure with a caption, the LaTeX result has the following
> shape:
>
> \begin{figure}
> …
> \caption{\label{…}
> Content of the caption}
> \end{figure}
>
> When compiling to LaTeX, the carriage return causes a indesirable white
> space in some cases. What I would expect is:
>
> \begin{figure}
> …
> \caption{Content of the caption}
> \label{…}
> \end{figure}
>
> To fix this, I have changed the org-latex--caption/label-string function
> in ox-latex.el on lines 1314 and 1315:
>
> (format (if nonfloat "\\captionof{%s}%s{%s%s}\n"
>  "\\caption%s%s{%s%s}\n")
>
> becomes
>
> (format (if nonfloat "\\captionof{%s}%s{%s}\n%s"
>  "\\caption%s%s{%s}\n%s")

IIRC, the label has to be included in the caption command. I applied
a different solution. Let me know if that works for you.

Regards,

-- 
Nicolas Goaziou

Re: Bug and quick bugfix

[Ken Mankoff]

On 2019-10-13 at 09:26 +02, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote...
> IIRC, the label has to be included in the caption command. I applied a
> different solution. Let me know if that works for you.

I thought so too. But I couldn't find a definitive answer for this when searching about this last night.

  -k.

Re: Bug and quick bugfix

[Vladimir Lomov]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

Hello,
** Nicolas Goaziou <mail@nicolasgoaziou.fr> [2019-10-13 09:26:42 +0200]:

> Hello,
> 
> Godefroy <godefroy.vannoye@gmail.com> writes:
> 
>> I recently encountered a bug when exporting an org file to LaTeX: when
>> generating a figure with a caption, the LaTeX result has the following
>> shape:
>>
>> \begin{figure}
>> …
>> \caption{\label{…}
>> Content of the caption}
>> \end{figure}
>>
>> When compiling to LaTeX, the carriage return causes a indesirable white
>> space in some cases. What I would expect is:
>>
>> \begin{figure}
>> …
>> \caption{Content of the caption}
>> \label{…}
>> \end{figure}
>>
>> To fix this, I have changed the org-latex--caption/label-string function
>> in ox-latex.el on lines 1314 and 1315:
>>
>> (format (if nonfloat "\\captionof{%s}%s{%s%s}\n"
>>  "\\caption%s%s{%s%s}\n")
>>
>> becomes
>>
>> (format (if nonfloat "\\captionof{%s}%s{%s}\n%s"
>>  "\\caption%s%s{%s}\n%s")
> 
> IIRC, the label has to be included in the caption command. I applied
> a different solution. Let me know if that works for you.

There is no strict rule but a general good practice: for caption
material put label command inside the caption macro. Otherwise there
might be some side effects.

> Regards,
> 
> -- 
> Nicolas Goaziou

---
WBR, Vladimir Lomov

-- 
QOTD:
	"I thought I saw a unicorn on the way over, but it was just a
	horse with one of the horns broken off."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Bug and quick bugfix

[Godefroy]

Thanks for your replies. Your solution works for me, thank you a lot for
your work.

Sincerely,

Godefroy Vannoye

On 10/13/19 1:21 PM, Vladimir Lomov wrote:
> Hello,
> ** Nicolas Goaziou <mail@nicolasgoaziou.fr> [2019-10-13 09:26:42 +0200]:
>
>> Hello,
>>
>> Godefroy <godefroy.vannoye@gmail.com> writes:
>>
>>> I recently encountered a bug when exporting an org file to LaTeX: when
>>> generating a figure with a caption, the LaTeX result has the following
>>> shape:
>>>
>>> \begin{figure}
>>> …
>>> \caption{\label{…}
>>> Content of the caption}
>>> \end{figure}
>>>
>>> When compiling to LaTeX, the carriage return causes a indesirable white
>>> space in some cases. What I would expect is:
>>>
>>> \begin{figure}
>>> …
>>> \caption{Content of the caption}
>>> \label{…}
>>> \end{figure}
>>>
>>> To fix this, I have changed the org-latex--caption/label-string function
>>> in ox-latex.el on lines 1314 and 1315:
>>>
>>> (format (if nonfloat "\\captionof{%s}%s{%s%s}\n"
>>>  "\\caption%s%s{%s%s}\n")
>>>
>>> becomes
>>>
>>> (format (if nonfloat "\\captionof{%s}%s{%s}\n%s"
>>>  "\\caption%s%s{%s}\n%s")
>> IIRC, the label has to be included in the caption command. I applied
>> a different solution. Let me know if that works for you.
> There is no strict rule but a general good practice: for caption
> material put label command inside the caption macro. Otherwise there
> might be some side effects.
>
>> Regards,
>>
>> -- 
>> Nicolas Goaziou
> ---
> WBR, Vladimir Lomov
>