From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kMXYAyHGl15zawAA0tVLHw (envelope-from ) for ; Thu, 16 Apr 2020 02:42:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OLceMyTGl161CQAAbx9fmQ (envelope-from ) for ; Thu, 16 Apr 2020 02:42:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 50C19941E18 for ; Thu, 16 Apr 2020 02:42:42 +0000 (UTC) Received: from localhost ([::1]:57196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOuUA-0003ex-TD for larch@yhetil.org; Wed, 15 Apr 2020 22:42:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44178) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOuTV-0003eU-TI for emacs-orgmode@gnu.org; Wed, 15 Apr 2020 22:41:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOuTT-0004W5-W2 for emacs-orgmode@gnu.org; Wed, 15 Apr 2020 22:41:57 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:62970) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOuTQ-0004U6-US; Wed, 15 Apr 2020 22:41:53 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id ADA6FD5DBF; Wed, 15 Apr 2020 22:41:49 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=djSgO8FoU+ks FGIyH0dBVyQzips=; b=KsQEpcXAqYOLJrqykoDAlJ/sI6vQRAbjn7ogdNuUDeeG LRwR/tjOHpYpjYaLiSgBkn3FqbovCrl73hsxwl2ZfYQydlAPBvg4NdGZS23Jl9Rj ljjU5xD8CNQfzha7ctZKOGMxGzvwW109x8OpyZtE0bjKew4g7BVT52v7aRfjrYI= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id A6443D5DBE; Wed, 15 Apr 2020 22:41:49 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=DMZUBVMZCT95CywQpAW18NhwQG8PDDKNh2ahY8BwiqE=; b=uyy3VNv8nsoDOImOL7i3TedacozD/MTCFLj9ydOdE0D3656BzbBesc2/OREfRUUjIudgLJz66qr1B5eT2HHx+bWlIFPdVUMKtT92GiBwcxp5lD3/EqPjBDvDEHCAyssgPXj4lzdtNZ0yft9SCA6CEOLoIVMxcwElq4Chi8l0AJY= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 2813ED5DBB; Wed, 15 Apr 2020 22:41:47 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Kaushal Modi Subject: Re: Debugging at least 2 regressions in org-mode master breaking ox-hugo In-Reply-To: <875zfrtw6m.fsf@alphapapa.net> References: <875zfrtw6m.fsf@alphapapa.net> Date: Thu, 16 Apr 2020 02:41:45 +0000 Message-ID: <878siww3rq.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: D0FEFF70-7F8B-11EA-A5D1-8D86F504CC47-24757444!pb-smtp21.pobox.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 173.228.157.53 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: -1.21 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=KsQEpcXA; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=uyy3VNv8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-1.21 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.57488227694488]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.26), country: US(-0.01), ip: 209.51.188.17(-0.57)]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; DKIM_TRACE(0.00)[pobox.com:+,kyleam.com:+]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[kyle@kyleam.com,emacs-orgmode-bounces@gnu.org]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[pobox.com:s=sasl,kyleam.com:s=mesmtp]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[kyleam.com]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[8]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: 5B2QKRrIb1gT Adam Porter writes: > Kaushal Modi writes: > >> Failure 1: org-get-outline-path has moved, and not mentioned in ORG-NEWS >> >> Compiling ox-hugo.el now gives: >> >> ox-hugo.el:4284:1: Warning: the function =E2=80=98org-get-outline-path= =E2=80=99 is not known to be defined. >> >> I see that defun has now moved to org-refile.el. I see that >> org-get-outline-path has nothing to do specific to refiling. Can that >> be moved back to org.el, or may be a separate library? Otherwise, >> ox-hugo.el will have to load org-refile.el too (yes, I don't use >> org-refile (yet), and that's how I discovered this :)) > > Yes, please move that function back. This is going to cause breakage in > a variety of packages that use that function but do not load > org-refile. I can hear the bug reports rumbling already... ;) Despite being sympathetic to any attempt to break up org.el, I agree that it'd be good to move the outline path functionality back. Also, there are a number of loading issues related to the org-refile move, which can be seen by running `make single'. I've prepared a commit that resolves these issues, which includes moving org-get-outline-path and friends back to org.el, on the km/refile-fixups branch: https://code.orgmode.org/bzg/org-mode/commit/18e58aa0d7fd367b3506891b633a= 493f402e9fee (It's not very useful to post it as a patch here because most of it's code movement that's better viewed with git-diff's --color-moved.)