From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QghOEbb4+F4IfwAA0tVLHw (envelope-from ) for ; Sun, 28 Jun 2020 20:08:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wzFwDLb4+F72MgAAbx9fmQ (envelope-from ) for ; Sun, 28 Jun 2020 20:08:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B883C9400C1 for ; Sun, 28 Jun 2020 20:08:21 +0000 (UTC) Received: from localhost ([::1]:54342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpdbA-000227-Br for larch@yhetil.org; Sun, 28 Jun 2020 16:08:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpdZN-0000zh-8Y for emacs-orgmode@gnu.org; Sun, 28 Jun 2020 16:06:29 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:59496) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpdZL-0002K1-F9 for emacs-orgmode@gnu.org; Sun, 28 Jun 2020 16:06:28 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 0F5AECFFE7; Sun, 28 Jun 2020 16:06:25 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=VnzMDU4j57aLxEqjm3oKjthEFyY=; b=bYQjiP F9ylxpNDJtVSTDfjEhkcLV8hp7Ck3SNYswHsK6RBj+LGdDk5Bje4K/OGcyMEUE6d JIyqqyqXDCg2lzJJ8ZcPbdzCYc7JKeZuOxmeuL08tZiNjlEMNV0wiWff+VH7J1Uf WsdYwfoVD1q/ZxxwbPSSBPQtGmbmqgXVDNA+c= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 061B7CFFE6; Sun, 28 Jun 2020 16:06:25 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=DwszEodw4i6dSPHizSIqFa1QKAnDLzxbEDhhFMgEldw=; b=Hc3ReRJluf7vSvEeZqLXErfzX6D8dYXkikT1BB0g1MDpVQx6si51FmsOfaYYUiT7v/vjvXk/dkCPgl+JjgcpcWPh1YzB99CwU3l2oRSQ/Cf1gpfQ0ChqXWiaPAwYyX6xsFNZ5PDNITQ9Z51JuYFwtEd8yFfwKRKq+/OMTtasmRQ= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 76921CFFE5; Sun, 28 Jun 2020 16:06:22 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Mario Frasca Subject: Re: [bug] select TODO items and unexpected behaviour In-Reply-To: <10f954f3-0f17-ff93-cb49-bfb256a5e664@anche.no> References: <01d77bed-49e4-51ef-3c56-868a27f39984@anche.no> <87o8p366pa.fsf@kyleam.com> <10f954f3-0f17-ff93-cb49-bfb256a5e664@anche.no> Date: Sun, 28 Jun 2020 16:06:20 -0400 Message-ID: <878sg7arb7.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: D68E260E-B97A-11EA-96C1-8D86F504CC47-24757444!pb-smtp21.pobox.com Received-SPF: pass client-ip=173.228.157.53; envelope-from=kyle@kyleam.com; helo=pb-smtp21.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/28 16:06:25 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=bYQjiP F; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=Hc3ReRJl; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: pountsuJjc+B Mario Frasca writes: > On 28/06/2020 01:32, Kyle Meyer wrote: >> Thanks for reporting. Looks like org-todo's call to org-map-entries has >> been broken since its introduction in 7.8.05. Should be fixed with >> 8a2eb7d1b. > > 3ed035ce3 > > with this patch, you don't need to locally redefine the > org-loop-over-headlines-in-active-region variable, do you? What have you tried on your end to answer that? Here are some approaches: * Read the commit message in 3ed035ce3 (org.el: Clarify argument in org-todo's call to org-map-entries). Does its explanation fit with your understanding? Perhaps it's wrong or not written clearly, but it seems like a good starting point. * Drop the let-binding of org-loop-over-headlines-in-active-region in org-todo, and try it out. Does it work as before? Better yet, step through the call of the function, comparing the behavior before and after. * Drop the let-binding and run the test I added in 8a2eb7d1b (org.el: Fix org-todo argument handling when looping over region).