From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id L+oCCjyQR18qSAAA0tVLHw (envelope-from ) for ; Thu, 27 Aug 2020 10:51:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gElyBTyQR1+gdgAAbx9fmQ (envelope-from ) for ; Thu, 27 Aug 2020 10:51:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3EC399403A8 for ; Thu, 27 Aug 2020 10:51:39 +0000 (UTC) Received: from localhost ([::1]:40956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBFVI-0001hP-IY for larch@yhetil.org; Thu, 27 Aug 2020 06:51:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFUx-0001hH-QM for emacs-orgmode@gnu.org; Thu, 27 Aug 2020 06:51:16 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:59296) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBFUv-0005vy-DC for emacs-orgmode@gnu.org; Thu, 27 Aug 2020 06:51:15 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id BEC0BF2D64 for ; Thu, 27 Aug 2020 06:51:08 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=cFwY7+qAAULm+Ji+WObQsPinAQ8=; b=wn9iV6 u5R2sZY2enYeV8/j2BidbkSOVIVG+4KI1Pyr8+/EHtdGpw+d2raerb9LTPZ8dJs/ d7pMsf2Vd2DCzI1946CqkJ/vaI4T8EX4P/o+Ilr6JumajJQHUBCTZlIHxLaYVdAN fPIr91pUqI6KPMSr988r7FnlNbVgT0PBG2CNE= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id B8ABAF2D63 for ; Thu, 27 Aug 2020 06:51:08 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=Yrvq3DUFabKIVABjZJu9YjdJYpTAqR6zvCMwL0lUaGc=; b=xwdC0hAoytyQa+jQnZAUDGGbgFiq54QiV7KJArUaUw1m1YeuKdZO56NVswETMSRsUf4CrNz3Iyk9oW42bQbDZNSS9alxt2bGW/yqldojlbI5jPXZ1ULyMEy+wkVbsmeKshgxCP5Y4tjzeAc50pLkiRdXcu0evyqRUpL9L+jCg0g= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id E4D63F2D62 for ; Thu, 27 Aug 2020 06:51:05 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: emacs-orgmode@gnu.org Subject: Re: new feature for consideration: other-tab for org-agenda-window-setup In-Reply-To: <871rjsquwy.fsf@ucl.ac.uk> References: <87eentqsws.fsf@ucl.ac.uk> <87k0xlm48z.fsf@kyleam.com> <871rjsquwy.fsf@ucl.ac.uk> Date: Thu, 27 Aug 2020 06:51:03 -0400 Message-ID: <878se0qs4o.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 3520EA10-E853-11EA-AFC1-843F439F7C89-24757444!pb-smtp21.pobox.com Received-SPF: pass client-ip=173.228.157.53; envelope-from=kyle@kyleam.com; helo=pb-smtp21.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 06:51:08 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=wn9iV6 u; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=xwdC0hAo; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: q2rHKV7ipl8J Eric S Fraga writes: > On Wednesday, 26 Aug 2020 at 18:28, Kyle Meyer wrote: >> Thanks. Sounds fine to me. > > Hi Kyle, > > thanks for the feedback. Some questions/comments: > >> Style conventions: s/added/Add/s/handle/Handle/ > > Okay although grammatically wrong but we won't go into that... ;-) (Eh, sorry about the lack of a space between my s/// expressions.) I assume you're talking about using the imperative mood with the "added => Add" change. I don't see what's grammatically incorrect about that. >> I think it's worth noting here which Emacs version gained tab support. > > Just as part of the comment? As part of the docstring, yes. Also, I should have mentioned that because the option value is changing, the defcustom should get a `:package-version '(Org . "9.N")`, where N is probably 4. (And of course a NEWS entry would be good.) >> As you suggest in your follow-up message, you need to guard these calls >> for the sake of older versions. Perhaps something like >> >> (if (fboundp 'FN) >> (FN ...) >> (user-error "Your Emacs version doesn't support tabs")) > > Okay; is there any way to guard the customization of the variable so > that the option does not get provided when it's an older version of > Emacs? You could conditionally set the defcustom value, but IMO it's not really worth the trouble. Either way I think the above call sites should be guarded. Thanks.