From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UGewAcvwUF/fWQAA0tVLHw (envelope-from ) for ; Thu, 03 Sep 2020 13:34:03 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qIQwOcrwUF8bVwAAB5/wlQ (envelope-from ) for ; Thu, 03 Sep 2020 13:34:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 57C46940291 for ; Thu, 3 Sep 2020 13:34:02 +0000 (UTC) Received: from localhost ([::1]:40606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDpNH-00013x-Pz for larch@yhetil.org; Thu, 03 Sep 2020 09:33:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDpMg-00010x-KP for emacs-orgmode@gnu.org; Thu, 03 Sep 2020 09:33:22 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:54528) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDpMe-00080k-OB; Thu, 03 Sep 2020 09:33:22 -0400 Received: by mail-pj1-x1031.google.com with SMTP id mm21so1539070pjb.4; Thu, 03 Sep 2020 06:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=4WWh+F8jXqNhslkgobAWUlmQ5UOdcLLtG4m3Aj/Cmsw=; b=LPBE0gL3bYzrmGMEchmbKgBwCte/x/fhFRKVZccCdqv1SpjL0fM//Y/3+Ixu/Dwfir Ufw+YX+WfD0u6kpqJg+dNXEDLUcJEc14dxoCFMm9dLCWQXwBESPpf+JSmowcexaxEK7f hSlGE6GO7HtFnu4WDwDtmipo5/8QIBRZ3a8p63iDmsifuzYNqmd6q76LSgY6oxDM6xJl TNZ8E2+ItiJ4NF/RAzkr+H8FGNF5ds0KHOwSwMbEDa0Ki/EwKtoKIZEVBREt5eb3VrCU 7rZu2BwFYm5Q6E6S1EFrc4lAZdNsTWZ9a1KHP+5+rr1PSeOH32jT++tJomOFS0FLMtIf hoOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=4WWh+F8jXqNhslkgobAWUlmQ5UOdcLLtG4m3Aj/Cmsw=; b=bQSj0r+0GZZVt2SShxWMtfhLydMF3WwxhNvDwKRAUkMZYuf9hwyx4L+axw9HMvzdxO NhmWcvqmaWyviInoM3vYLl5G2U5N9+ql43usl+RhKUYLWR4xedZfbaVQg/7BCHEr/Atw bvcavbgW/gt9r4fDFEn2VjLkC3+B+ughu5LV6UJE9CZTj9VwKk/GtE1PwrjiKeEIZx4o 41K3pvlmKkTsVpbarPEFT1frp/yt33BglLlEHtDWBQRmOBX+CM0Ktp17PnydWlpN0FVo 2PShyFSipTBGy1VkDFzqGz/AwvjZsnFrcr99rlHIedilS3z7Y1QFnlnJKlV7Ch+hNFMZ rD8w== X-Gm-Message-State: AOAM533FMJXDi5dVg5A5WGxmhyvYuo1JTzDahQUxex8F81iVP+bGLKfw DjjQf276az/iNkp1FxtFIsFmxhPKMGU= X-Google-Smtp-Source: ABdhPJz0zv0M7vO3kFftSdewy37thRJWrWjYhemDPuP/+X4GdLz8py/26CXCeYBV4H7qtcotfVUZ9w== X-Received: by 2002:a17:90a:9307:: with SMTP id p7mr3356645pjo.105.1599139997321; Thu, 03 Sep 2020 06:33:17 -0700 (PDT) Received: from localhost ([66.154.105.2]) by smtp.gmail.com with ESMTPSA id e7sm3380742pfm.43.2020.09.03.06.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 06:33:16 -0700 (PDT) From: Ihor Radchenko To: Bastien Subject: Re: Default value and docstring of org-attach-store-link-p In-Reply-To: <87ft7zyws1.fsf@gnu.org> References: <87imd2yth5.fsf@localhost> <87ft7zyws1.fsf@gnu.org> Date: Thu, 03 Sep 2020 21:32:17 +0800 Message-ID: <878sdrm1em.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=yantar92@gmail.com; helo=mail-pj1-x1031.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=LPBE0gL3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: OYe9CkB5qOfO > I don't have a strong opinion here. > > Why do you think it would it be a better as a default? It seems that other people expect it to be default [1]. Also, I am using org-attach heavily in my workflows. Most of the time I found myself inserting the link to attachment right after attaching a file. Finally, it do not see any drawback adding the link to history vs not adding. I personally would prefer 'attached as a default, but it is mostly because I use org-attach already and attach: link would be shorter. Probably, 'file as default is safer if the user changes the :DIR: property for some reason. [1] https://www.reddit.com/r/emacs/comments/ihzh9r/orgmode_quicker_way_to_create_link_to_attachment/ > Feel free to propose a patch for this and the suggested switch, we can > apply it after Org 9.4. I will add it to my todo list. This should be lower priority than org-fold.el Best, Ihor Bastien writes: > Hi Ihor, > > Ihor Radchenko writes: > >> The default value of org-attach-store-link-p is nil for now. >> Would it make more sense to set it to something else (say, 'attach)? >> I believe that 'attach or t would be better as a default. >> >> Thoughts? > > I don't have a strong opinion here. > > Why do you think it would it be a better as a default? > >> Also, the docstring does not mention that there may be several different >> non-nil values. It is only reflected in the :type field of defcustom. > > Feel free to propose a patch for this and the suggested switch, we can > apply it after Org 9.4. > > Best, > > -- > Bastien