emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Default value and docstring of org-attach-store-link-p
Date: Thu, 03 Sep 2020 21:32:17 +0800	[thread overview]
Message-ID: <878sdrm1em.fsf@localhost> (raw)
In-Reply-To: <87ft7zyws1.fsf@gnu.org>

> I don't have a strong opinion here.
>
> Why do you think it would it be a better as a default?

It seems that other people expect it to be default [1]. Also, I am using
org-attach heavily in my workflows. Most of the time I found myself
inserting the link to attachment right after attaching a file. Finally,
it do not see any drawback adding the link to history vs not adding.

I personally would prefer 'attached as a default, but it is mostly
because I use org-attach already and attach: link would be shorter.
Probably, 'file as default is safer if the user changes the :DIR:
property for some reason.

[1] https://www.reddit.com/r/emacs/comments/ihzh9r/orgmode_quicker_way_to_create_link_to_attachment/

> Feel free to propose a patch for this and the suggested switch, we can
> apply it after Org 9.4.

I will add it to my todo list. This should be lower priority than org-fold.el

Best,
Ihor

Bastien <bzg@gnu.org> writes:

> Hi Ihor,
>
> Ihor Radchenko <yantar92@gmail.com> writes:
>
>> The default value of org-attach-store-link-p is nil for now.
>> Would it make more sense to set it to something else (say, 'attach)?
>> I believe that 'attach or t would be better as a default.
>>
>> Thoughts?
>
> I don't have a strong opinion here.
>
> Why do you think it would it be a better as a default?
>
>> Also, the docstring does not mention that there may be several different
>> non-nil values. It is only reflected in the :type field of defcustom.
>
> Feel free to propose a patch for this and the suggested switch, we can
> apply it after Org 9.4.
>
> Best,
>
> -- 
>  Bastien


      reply	other threads:[~2020-09-03 13:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29  4:19 Default value and docstring of org-attach-store-link-p Ihor Radchenko
2020-09-03 10:33 ` Bastien
2020-09-03 13:32   ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sdrm1em.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).