emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Vasilij Schneidermann <mail@vasilij.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: [PATCH] org-datetree-insert-line doesn't honor headline spacing customization [9.3 (release_9.3 @ /usr/share/emacs/27.1/lisp/org/)]
Date: Wed, 09 Sep 2020 10:08:19 +0200	[thread overview]
Message-ID: <878sdjnzik.fsf@gnu.org> (raw)
In-Reply-To: <20200908201845.GA1346@odonien.localdomain> (Vasilij Schneidermann's message of "Tue, 8 Sep 2020 22:18:45 +0200")

Hello Vasilij,

Vasilij Schneidermann <mail@vasilij.de> writes:

>> Thanks for the patch.  I tried it and these two tests fail:
>> 
>>    FAILED  test-org-datetree/find-date-create
>>    FAILED  test-org-datetree/find-iso-week-create
>> 
>> Perhaps you can check the value of `org-blank-before-new-entry' and
>> insert a blank line only if needed?
>
> I've looked at the tests and concluded that your proposed approach is better
> and updated the patch accordingly.

thanks for the updated patch, I added a changelog entry and applied it
as 5082e436a in master.

Best,

-- 
 Bastien


      reply	other threads:[~2020-09-09  8:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03  8:50 Bug: [PATCH] org-datetree-insert-line doesn't honor headline spacing customization [9.3 (release_9.3 @ /usr/share/emacs/27.1/lisp/org/)] Vasilij Schneidermann
2020-09-05 14:57 ` Bastien
2020-09-08 20:18   ` Vasilij Schneidermann
2020-09-09  8:08     ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sdjnzik.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@vasilij.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).