From: "Thomas S. Dye" <firstname.lastname@example.org> To: Timothy <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH] LaTeX export: arbitrary float environments Date: Sat, 01 May 2021 07:20:25 -1000 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Aloha Timothy, Thanks for your kind response. Sorry for the clumsy patch, which I guess would also benefit from an addition to the manual, as well? Larger question: do we really want to tinker with ob-latex in this way? Or, should changes like this patch follow a path indicated by Tim Cross and into their own package, say ob-latex-ex, which might someday replace ob-latex if it proved useful and stable? All the best, Tom Timothy <email@example.com> writes: > Hi Thomas, > > On the surface, this looks reasonable to me :) > > Just commenting on some technicalities with the patch itself: > - In ORG-NEWS it would be good to wrap the content over multiple > lines > instead of having a single 270 char line :) > - You seem to have an anomalous change to the ob-python :return > entry > - I don't think your patch subject follows the convention for > Org, it > should be: > "main file/feature: overall change summary" > so, something like > "ox-latex: allow for arbitrary float environments" > rather than > "LaTeX export: arbitrary float environments" > > Thanks for the patch :) > > Timothy -- Thomas S. Dye https://tsdye.online/tsdye
next prev parent reply other threads:[~2021-05-01 17:21 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-04 18:46 Thomas S. Dye 2021-05-01 11:08 ` Timothy 2021-05-01 17:20 ` Thomas S. Dye [this message] 2021-05-01 17:31 ` Timothy 2021-05-15 13:22 ` Bastien
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] LaTeX export: arbitrary float environments' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).