From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oP4EEfFs/GDaMAEAgWs5BA (envelope-from ) for ; Sat, 24 Jul 2021 21:41:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UPt/DPFs/GBiKAAAbx9fmQ (envelope-from ) for ; Sat, 24 Jul 2021 19:41:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A40FF1FBE9 for ; Sat, 24 Jul 2021 21:41:36 +0200 (CEST) Received: from localhost ([::1]:53432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7NWg-0006UD-IZ for larch@yhetil.org; Sat, 24 Jul 2021 15:41:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7NWG-0006Tr-I4 for emacs-orgmode@gnu.org; Sat, 24 Jul 2021 15:41:08 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:41548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7NWF-0002xs-1k for emacs-orgmode@gnu.org; Sat, 24 Jul 2021 15:41:08 -0400 Received: by mail-pj1-x1035.google.com with SMTP id q17-20020a17090a2e11b02901757deaf2c8so8634748pjd.0 for ; Sat, 24 Jul 2021 12:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=+U94qWHotWrfYzEe0iTfjvdnPyp0wmdHZ+t9fdVWkMQ=; b=AD+srBQmHLhJ0WW+MrjYRgAqeXJvZtXgVdt8EqR4/PBRpnUDDez4f9Fb513HssQ3ms +1t6yUtU62sbny9kVgACstuxYoFxfMk4V7ZprKZ7OIKXU/789H9p3/s4am91ZfGLc4mu rkjqBshuVwX4nhfEBRZRMy63RYG9LsKjaiMDI7niafT8xEKqHZ4cWtYiGmf5+vusreJd 4cZSyeWcIsdzGWVaPj9BW2WzC2vW0TbQ9FMjSR+sCITLnkCZzJoLN0skhB+BjcMb1xgx LOZOFf4ck6FvAeyqgGqpNWxt+uAlYKmETopVC374EpNwNzdFvd/XEALeuKeuCEQYlwZV MApQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=+U94qWHotWrfYzEe0iTfjvdnPyp0wmdHZ+t9fdVWkMQ=; b=jlGBHBgYN9+qdM71+QlyL6F6DpA5nEyNGvripOO1aNjdbDxUikbAv7xDbJTVY3nPsX GR7PQt2Iha6c0v5xkhdOQEEVulyJub4ibwcULfLon7MWbFQvxkmcZG5dOjAAQpoEvJLR SDIv/ysuihRnSVcMGn+rHLBbwSFgWgaeCfbMEvPpgvmy54hvYp6ac+U1OGdCogM0nmA5 v5/9+xU/g6/qfzZvIxEaWVIDHwOlS25GS1UflyIRdIB7/h+3YyzADNfKNjHJ4QC6g1h6 FdDMrfMqdnEWfjgVXabfprjibAQWGl1TNuF0a7gtvz+547tcNKj0EEkjXzsJFRap/rOE bYNQ== X-Gm-Message-State: AOAM531jaO5sg6X4nwxQ8z9kT+HLXDNHJyuTbnSz2SkCIAmyM0KfVn7p 9IBk663LRzd/JhrMe5nNv/A= X-Google-Smtp-Source: ABdhPJyy6oB0EsETpxtF1k4JPPqY2LEPPbKOJrI/YejACt6Z4r1Gqh7Vi5kUItVTzKt1AYVY2cw/vA== X-Received: by 2002:a63:ff4d:: with SMTP id s13mr10772204pgk.237.1627155665536; Sat, 24 Jul 2021 12:41:05 -0700 (PDT) Received: from localhost (180-150-91-8.b4965b.per.nbn.aussiebb.net. [180.150.91.8]) by smtp.gmail.com with ESMTPSA id n17sm72667pgf.90.2021.07.24.12.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 12:41:05 -0700 (PDT) References: User-agent: mu4e 1.4.15; emacs 28.0.50 From: Timothy To: Tom Gillespie Subject: Re: [PATCH] ob-core: tangle check library of babel after current buffer In-reply-to: X-Woof-Patch: applied Message-ID: <878s1vjy9d.fsf@gmail.com> Date: Sun, 25 Jul 2021 03:41:02 +0800 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=tecosaur@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627155696; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+U94qWHotWrfYzEe0iTfjvdnPyp0wmdHZ+t9fdVWkMQ=; b=Gg6RppCeQb4EB+A0oVcWWD2G8DhrSoS319bRGbWaKrvLXx9TmTr5WI6xIEmRIyT571FHEW qEWsF0nqOQpmLhrVnPSLI86Ghe9PILb+X3WN7zGr5S9shF9RbWyHAyHfUwHQqovnbVQsrG zKRuXmDeLb34tFMRpRnqjvsgoOPNMw6egblR5FNjv/svcbn3Be/wq0h/JYezTBH7xV5dM/ TCWhKLgHq2gDoI217JA0+5NPKG4F4Y5/mR4ZzBnfSEIAeWvBRD/WEIMcrjcPIkz+/wq4Le DWy8wedHQHnIwZlBrjGG6mvghqWalkVuKwsgMBvzjcehP/S4t06h+UouQENGBg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627155696; a=rsa-sha256; cv=none; b=r5zwbgC4xAAFmzLxsQYkOA1124WGoyASnLgRGMXneOqbRjfAAFsobtl5aHWj6KmbD4m08v b74l6GJVHy3WxWq3ipbM17ZzkB/BiEw9q7+4ZF0Na3KGHt0l+ftu06DM4zexG+RnJEdh63 RZDimYPUj3VzEVJ0CJeDpjLKzSq4lkFqcgyQ9Pn4qsytFzhLass0NvhXeUB6hcc8vlJMMx wt9nP4DbqkVOzivn0/aTCrXcavRHXsZYCD4etdVTHJzvpW0RhbRASasH2bDi1fvY9FYJr3 SyCa0/w42YhzmVfJRh8ZxM66+aigiBEcRRC6CwRreCA3gF9YZ7VB7RMgsSaPWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=AD+srBQm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=AD+srBQm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A40FF1FBE9 X-Spam-Score: -3.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: i5/M9LKmH/xx Hi Tom, Sorry that it's taken so long for someone to get to this. I've just applied your patch to my local Org instance, and then tested the described behaviour before and afterwards. I can confirm that the issue reported exists, and that your patch fixes this. In light of this and the two other positive reviews here, I feel it's pretty safe, and so have applied this patch as f052acee5 :) -- Timothy Tom Gillespie writes: > Pinging on this to see if anyone can test it so that it can be merged. > Tom > > On Wed, Jun 16, 2021 at 4:29 PM Tom Gillespie wrote: >> >> Hi, >> This is a patch that fixes tangling behavior when a block has been >> ingested into the library of babel and then modified. Best! >> Tom -- Timothy