From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uO5gAtERLmHFygAAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 13:26:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MF94OdARLmHTJQAAbx9fmQ (envelope-from ) for ; Tue, 31 Aug 2021 11:26:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DFEB01D91C for ; Tue, 31 Aug 2021 13:26:07 +0200 (CEST) Received: from localhost ([::1]:36318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL1u2-0005kw-81 for larch@yhetil.org; Tue, 31 Aug 2021 07:26:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL1sv-0005j6-Ji for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 07:24:57 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:41588) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mL1st-0003CV-Vc for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 07:24:57 -0400 Received: by mail-pj1-x1031.google.com with SMTP id z24-20020a17090acb1800b0018e87a24300so2171369pjt.0 for ; Tue, 31 Aug 2021 04:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version; bh=t6XpQ1VYctIsOUXvT4GCD3HUsvA5EQt2mbgEE3TwHjc=; b=FahrE0OHTvKmhbek3ZEpCtcolra9JSFszadrd1UImMuimisYG1j8WFI0iLFMVaZZjG H3Yf/7lAl8O/AMfTDSSFrBJCy3+3+wRnKgFBlX32FcrUzoMwwXHFzQ/zGN1eInGM8xY6 o+rRRHKciWUazZfa3yBS4yFxyAcoGANscZ494rZKMSO51oBUwBfg0w5jz6i0se64Xdlh yVAa8TxIc1ZBzMgzPXrh4owm4JATKlk+9H8ONfZVmpCur8JRJAtAQ+507hyzcBhMLQMD J5dUwyvn6m7AV+9O7H0dxFbkittPO1SEg3OlJxqPcdrDkk0wGxZJnlJa68R5wEky65yn fM0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version; bh=t6XpQ1VYctIsOUXvT4GCD3HUsvA5EQt2mbgEE3TwHjc=; b=cmeEZLTL6w3de8k3jQg35DszGozxFRLvLdtnuv5nF2lC3ZJeamItYtctLIZrRTuT6t rZblJ3p4na5r0ZrbUPvWM7NONkd6tyfLjVG/y5QDw8or8lGIJ6GL7jOouGMqUknQnNoh tNNav4QXOkpZyoV06v10fsSCvaHHiaBGjTunJZnsqrM3xBqc35lUkBfCMqZDMYrlM9LO v1NnnnloXXPoCnujwtDsDpoqQ1M68gzV1G95mV3NZW86H5+/vx1xZUjx4SFwfOJAHZJl bG3sLrTnI0gp9QocIrbO9xLTfeQug84z+VzEyTYds6UG4A9OsLNKlg7c6qqMtVNjnOZt PNQQ== X-Gm-Message-State: AOAM532HLPrJXYkIK4ehY2PjNH3XTwaScGSEQZZRug2oT2kGnqObmi2o f5uVzLEHEYWnZwKqc5pHnK8= X-Google-Smtp-Source: ABdhPJzv6AWcQeAO5MjXRibnjd83dmMA4A3di/ytTCzNy93QTA1BTsDu7FEDLpOoh98qcVe5//W/YQ== X-Received: by 2002:a17:90a:890f:: with SMTP id u15mr4664322pjn.149.1630409094474; Tue, 31 Aug 2021 04:24:54 -0700 (PDT) Received: from localhost (61-245-128-160.3df580.per.nbn.aussiebb.net. [61.245.128.160]) by smtp.gmail.com with ESMTPSA id v186sm18290592pfb.178.2021.08.31.04.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 04:24:54 -0700 (PDT) From: Timothy To: Ryan Scott Subject: Re: New source block results option for attaching file to node Date: Tue, 31 Aug 2021 19:15:40 +0800 References: User-agent: mu4e 1.6.5; emacs 28.0.50 In-reply-to: Message-ID: <878s0hq2kc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=tecosaur@gmail.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630409168; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=t6XpQ1VYctIsOUXvT4GCD3HUsvA5EQt2mbgEE3TwHjc=; b=E2iU6KWQOoTQCK8enfFjhLrihi6VC9W+1CN6W7UcnsmPRGEp8175Gb7ROrhKH3p2Ww6z6G f/b7fcPoMomF/9SKKtEbcuh2UqU+12vcMyDR+ik43khnNhpQgqsa4qTqFbWsYf39iZ6v1q /oHBFz455/XtbRuAtX85UidDxObMOnSGh1Vo42oofJ7WWMhafk7r98biOth2dQgt/ZpN1I +GE7TGZeS8lnTwkuDwiY7OMB5MC5NtX1Qp0q1tiUxOxZlZ9e+xupnOseB2Pd4rf6nj1Iih xL7w4IcWB7OEE04tKbd7YiuIq1X/7a/GO3L5irH+g/VyQXwlU80kWJKCjyt3JQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630409168; a=rsa-sha256; cv=none; b=d/bI2F+yHAN0LefWdHO6+u6x0TyFBGjWimGTUsv/BmCsYanpr9IM/rlJC4QQDHIjyw+oe1 6KN5/EREzLmFBfLT+aski/q8CoJ4L6ix2k/KYcACyKhqC6gvDVTLkJsI+wzcDcpihlcdtw Cs1c+tGHV/DD8D855VYGzQuVARzp7+MaTE4hVBrp0JkvwKxZjfe77eDkYo97HxA1g4C6nj NofswtM2zvN1ceSbbnRIWyaHVrQFdpHXZ821MByBBOpMzqxeo+ZiVgsEarM9GhlIh3jDEi YEXggL9IwNdD6c5gKD2XgC+UROQ89eBsgzs700Hg1P3rJcWVxqGnPLP7ywrRbg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=FahrE0OH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.62 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=FahrE0OH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: DFEB01D91C X-Spam-Score: -0.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1O24eMGWstnb --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Ryan, Thanks for submitting your first patch to Org! =F0=9F=8E=89 Regarding the purpose of the patch, I take it this is useful with source bl= ocks that return a file patch and should be added as an attachment? Would you mi= nd expanding on this use case? Oh, and `org-attach-dir' doesn=E2=80=99t show u= p a function or variable for me, I take it you meant something else? Lastly, with your commit message, you=E2=80=99ve clearly looked at the requ= ested commit message format =F0=9F=98=8A. There=E2=80=99s the odd typo (=E2=80=9Ctheh=E2= =80=9D) and the line length is too long. It=E2=80=99s good if you hard line-wrap to 72 characters (if you use = Magit, this should happen automatically FYI). Other than that it looks good to me. All the best, Timothy --==-=-= Content-Type: text/html; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable

Hi Ryan,

Thanks for submitting your first patch to Org! =F0=9F=8E=89

Regarding the purpose of the patch, I take it this is useful with source bl= ocks that return a file patch and should be added as an attachment? Would you mi= nd expanding on this use case? Oh, and org-attach-dir doesn=E2=80=99t show up a function or variable for me, I take it you meant something else?

Lastly, with your commit message, you=E2=80=99ve clearly looked at the requ= ested commit message format =F0=9F=98=8A. There=E2=80=99s the odd typo (=E2=80=9Ctheh=E2= =80=9D) and the line length is too long. It=E2=80=99s good if you hard line-wrap to 72 characters (if you use = Magit, this should happen automatically FYI). Other than tha= t it looks good to me.

All the best,
Timothy

From: Ryan S= cott
Subject: New source block results option for attaching file to node
To: emacs-orgmode@gnu.org
Date: Thu, 26 Aug 2021 16:48:50 +0800

An additional option for use with ":results file= " that moves the returned path to the node attachment directory (as re= turned by org-attach-dir), creating it if necessary.

<= div>First time submitting a patch. Any feedback is appreciated.
<= br/>
-ryan

--==-=-=-- --=-=-=--