emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] 81c7a2dee8 misaligns time lines in agenda
Date: Sat, 25 Sep 2021 21:46:39 +0200	[thread overview]
Message-ID: <878rzkcuao.fsf@gnu.org> (raw)
In-Reply-To: <87czr6uhhk.fsf@alphapapa.net> (Adam Porter's message of "Sun, 25 Jul 2021 18:00:07 -0500")

Hi Adam,

Adam Porter <adam@alphapapa.net> writes:

> In the course of working on a PR for org-super-agenda [0], we found that
> a recent change to Org, commit 81c7a2dee8 [1], causes a misalignment in
> the way time lines in the agenda are displayed.  The org-super-agenda
> test suite shows this change when results from Org 9.4 and 9.4.6 are
> compared.  For example, in this diff of an agenda buffer:
>
> #+BEGIN_EXAMPLE diff
>  @@ -2,8 +2,8 @@
>  Wednesday   5 July 2017
>  
>   Today
> -  test:        7:02...... Sunrise (12:04 of daylight)
> -               8:00...... ----------------
> +  test:       7:02......  Sunrise (12:04 of daylight)
> +              8:00......  ----------------
>                10:00...... ----------------
>                12:00...... now - - - - - - - - - - - - - - - - - - - - - - - - -
>                12:00...... ----------------
> #+END_EXAMPLE
>
> The old lines, with single-digit hours, were properly aligned with the
> lines with multi-digit hours, but the new lines are one character too
> far to the left.
>
> Since Bastien made this change, and it's very simple, I'm guessing he'll
> know what the proper fix is.  :)

The change I made was superceded by Nicolas series of patches:

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/?qt=grep&q=fix+org-duration-to-minutes+error

I agree the new alignment looks wrong: the starting time should 
bit right-aligned with other time above/below, and the separating 
dash should not spaces for "HH:MM" time strings on the right, but
only for " H:MM".

Would you have time to prepare a patch for this?


  reply	other threads:[~2021-09-25 19:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25 23:00 [BUG] 81c7a2dee8 misaligns time lines in agenda Adam Porter
2021-09-25 19:46 ` Bastien [this message]
2021-09-26  2:53   ` Adam Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rzkcuao.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).