From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id o2OgNPZ/i2FJAwAAgWs5BA (envelope-from ) for ; Wed, 10 Nov 2021 09:16:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KLPCL/Z/i2FRXAAA1q6Kng (envelope-from ) for ; Wed, 10 Nov 2021 08:16:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C5882F875 for ; Wed, 10 Nov 2021 09:16:54 +0100 (CET) Received: from localhost ([::1]:37086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkimq-0006bA-Ox for larch@yhetil.org; Wed, 10 Nov 2021 03:16:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkimF-0006ZS-ST for emacs-orgmode@gnu.org; Wed, 10 Nov 2021 03:16:15 -0500 Received: from [2a01:488:66:1000:2ea3:4d27:0:1] (port=53622 helo=thenybble.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkimE-0007oD-3v for emacs-orgmode@gnu.org; Wed, 10 Nov 2021 03:16:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thenybble.de; s=two; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To :From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZGQbCgg9lEpshcHCKnkdo4AMH9Z/1XfHSoDZp6i60qY=; b=xu5busaOIlSM4Zv0JADvr8lTy0 HMOaFJOAMPiYSG/dRUjL9WdSNQv4kl+SLpywiOrFkzic2MW55n8F3CO66t91sO/RlNkISZnodfS7t gV/keBKN9rA7G23vjxHPEubEZhAH7AOHE3BcJRJvEpAZmbur1Id6FMuqayPoFBL8wQ78=; Received: from [2001:16b8:2de6:e600:1e69:3126:da43:d223] (helo=dumper) by thenybble.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkiNf-0006ex-EC for emacs-orgmode@gnu.org; Wed, 10 Nov 2021 08:50:52 +0100 Received: by dumper (sSMTP sendmail emulation); Wed, 10 Nov 2021 08:50:51 +0100 To: emacs-orgmode@gnu.org Subject: Bug: org-no-popups disregards display-buffer-fallback-action [9.4.6 (9.4.6-13-g4be129-elpaplus @ /home/jeeger/.emacs.d/elpa/org-plus-contrib-20210920/)] Date: Wed, 10 Nov 2021 08:50:49 +0100 Message-ID: <878rxw5u06.fsf@thenybble.de> MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:488:66:1000:2ea3:4d27:0:1 (failed) Received-SPF: permerror client-ip=2a01:488:66:1000:2ea3:4d27:0:1; envelope-from=jan.seeger@thenybble.de; helo=thenybble.de X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" Reply-to: Jan Seeger From: Jan Seeger via "General discussions about Org-mode." X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636532214; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZGQbCgg9lEpshcHCKnkdo4AMH9Z/1XfHSoDZp6i60qY=; b=IdcV8VonubGZBuI5DZFOys4r911RIDz2jh3upVFciCd9BuVNjQqVK3+EfcmUwPj80XfDXk I5Qb1G2CD7HFWBToT6y9xTfCj214fX5vFXezAnIRRrvl6ZAugPTnEe46UIE9M5NxkXfJ+i W6+j0FirC+IdiRswL0dOyfVPjRD1GSGmj74a9XdMRv0LJtB+o40zkvdiVHFbcABXtdcIvY DQ55xWSW1BQrJ4okfRQmU2b0qDgAvmwg9X5lQ2UeHofnQ1RSc2CmMFIC0+g845GiE3iyYc qRu+62yKFqlCxmkEOEm6OX5z1hHTdau2J6qcLVJB/siXQ1EQ50pgsMQydsgQew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636532214; a=rsa-sha256; cv=none; b=rB4DyVv3rCCZVFtSURWmMc5TAakNyhgWhFCUuGD3oBvoDyW7P3dRddtMUBKTKWHuyxaANR mAMRPriMRGiTDE/Ed09tZ+Wtp9yK2KSW66cma/eluBzPSkem84QYmSWjtvRe9ZJwGmHzZq 0TDfhQNL9ygie6kD7HTsp8ofTr94uVNS2FqIOgH/Zk2J/luV194xDXck87pvnhvqlRUoxM 6g7he4pSurnYXg4m8UyG+BEkno/RBrGI5nn8vOsjw6HQcZq8X1xW35b061gqxD3GN1GANw rCV9oL+ilBFvruggwyuoNSZ4IzxtHz132dSP6l1Fs9L2k+tOkt3g4yrAGAegig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=thenybble.de header.s=two header.b=xu5busaO; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=thenybble.de header.s=two header.b=xu5busaO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 5C5882F875 X-Spam-Score: -3.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: b8ba1eXIyhng Hello! I'm trying to make multi-frame emacsing nicer, and I encountered what I consider a bug with the `org-no-popups` macro in `org-macs.el`. `org-no-popups` tries to surpress the creation of new frames via setting `pop-up-frames` and `display-buffer-alist` to nil temporarily. This does not take `display-buffer-fallback-action` into account, which is the preferred way of making Emacs pop up new frames (or not, as the case may be). When the fallback variable is set, code run inside `org-no-popups` still creates new popups, which causes functions such as `org-insert-link` to fail, or at least act *very* confusingly. The preferred way of overriding the behavior of `display-buffer` for localized Emacs code seems to be the variable `display-buffer-overriding-action`. Changing the definition of `org-no-popups` to ``` (defmacro org-no-popups (&rest body) "Suppress popup windows and evaluate BODY." `(let ((display-buffer-overriding-action '(display-buffer-pop-up-window))) ,@body)) ``` correctly makes org pop up windows instead of frames. Please contact me if you have any questions! Best regards, Jan Seeger --- Emacs : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0) Package: Org mode version 9.4.6 (9.4.6-13-g4be129-elpaplus @ /home/jeeger/.emacs.d/elpa/org-plus-contrib-20210920/)