From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gFSLBAinvWIDHAAAbAwnHQ (envelope-from ) for ; Thu, 30 Jun 2022 15:37:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2NdWAwinvWJd+gAAG6o9tA (envelope-from ) for ; Thu, 30 Jun 2022 15:37:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0E35B622 for ; Thu, 30 Jun 2022 15:37:11 +0200 (CEST) Received: from localhost ([::1]:35860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6uM2-0006c2-Op for larch@yhetil.org; Thu, 30 Jun 2022 09:37:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6uKr-0006aB-CD for emacs-orgmode@gnu.org; Thu, 30 Jun 2022 09:35:57 -0400 Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32]:36736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6uKp-0000gZ-PV for emacs-orgmode@gnu.org; Thu, 30 Jun 2022 09:35:57 -0400 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-101ec2d6087so25825683fac.3 for ; Thu, 30 Jun 2022 06:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=3LhFC9dZt97AImHeRPyY9b/Jt5zahjeq1D9OvgWcytI=; b=eLqqFqkaTL98RcJzRVRTZZiZ+kR3qRa4FOvi+QYDs4RBkvpKqj5WbMJlI3/CwQCZoh eHF0Mu/OAfAR9a1L7LU3JP+sQLqQqmwe/S+c9TLcxpibaQj2DM7ZB8hA6PBdn71hZ9wJ fAx8Zvt3zLhHBPYSw9VM9ItTWoAIbUyTmMrp3NIZD06tcX8EnoVBQPh4kYQnC7+qwH30 NSVBFtpSsGFPgeKf52D4aoSAwbX/k9QxBzxu+EKZBjT3dU1PREt76y6IV2EQOG/Z4E2M QZjfy6H1H6u92PnrfpPMjVFDrLkh/CXQKyC6zcykYz9LInmM/i1pHzRhuq+0Y+CbYXp/ +N6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=3LhFC9dZt97AImHeRPyY9b/Jt5zahjeq1D9OvgWcytI=; b=Wy3peztHfUX/yUuZzNJvt0Zex+RgMG68PgqdJulkMom4m6OkKVJR/Q+ClD0D99TSJL GUecEvNvREAc7m28bI8+eWuSbQ0ZrQ9hpimJwdVl8Ddrafao+PZR2MdulZwcSpZZiYTg GSVbL7HG7GqArCECE0hQdO0lqDMnenEs2HjBv4nRExRejfXaHQte+0ChmLou7mEHc9qN vSzssAkDU+p5Kf+zFA0/Nfk6NmOV23TZgBbf7mA8c06vwPl+/CBXlfm/jFAbx6ma0Szi ObUAE4JG03O/6moRof6uP9PJ2FPINjtpFVHJFgWm/K5grILmF9GqFjV0lrYw5W4IkgJf zmDQ== X-Gm-Message-State: AJIora8DFN8O2SVMfZS+ghQwTrx+uaQNvHMfcL19M1EDk85jW6fTdogT O97U3xxuHqwoV/M+waAE5BE= X-Google-Smtp-Source: AGRyM1s0rk1uTLx+mNRKlm3h+FcLLTenTAXgqjM90yGIaXJiG5I4F718hSGa4G80lgFdknyOsKixHQ== X-Received: by 2002:a05:6870:45a9:b0:10a:9ebc:63ab with SMTP id y41-20020a05687045a900b0010a9ebc63abmr5001227oao.209.1656596154472; Thu, 30 Jun 2022 06:35:54 -0700 (PDT) Received: from localhost ([207.126.88.10]) by smtp.gmail.com with ESMTPSA id m14-20020a05683023ae00b00616958279dcsm10938463ots.79.2022.06.30.06.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 06:35:53 -0700 (PDT) From: Ihor Radchenko To: Stefan Kangas Cc: Org-mode Subject: Re: [PATCH] Delete some Emacs 24 compat code In-Reply-To: References: Date: Thu, 30 Jun 2022 21:36:57 +0800 Message-ID: <878rpe6znq.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4860:4864:20::32; envelope-from=yantar92@gmail.com; helo=mail-oa1-x32.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656596231; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3LhFC9dZt97AImHeRPyY9b/Jt5zahjeq1D9OvgWcytI=; b=gSbhFM8qGfMboKBuqH35mGIAJrqIPJ4OKeRbmP/JNTOnleHPVK2Ws7UZNbGtSLRxo0QmjY brpZmiu6hi7skDG3R7GZ3jxXsyoJkV5hGKUuwgMvFcjrpEtmBHOChBWupAlbHFR0z3oyJZ hu7Nw+FkCyEafpaFEaj0s5F+0tOma5cQNnYEQdX/nyDkj6VJnox7/aYlfrAHFKjmwLZTJU Y1yvEMpvFsXOlK4RAu6VpZ2qZ4G/o3Xxng8gxdkBxuYOa2VBcPDvFwMoD5D2RpkkimU99l dqWDp3zhiUr+Gi7iUdAY3PplLUB6eMYe/pzgW7VUkkK+K8QOmcJB4EBM6iRy/g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656596231; a=rsa-sha256; cv=none; b=tejMeMBLg55zcJ7hMQ2IoY75tVJs1ipm4x7IBNlc7kBak64genc0MV+OXfYDw1ZNtdz1rE yA9vFAwlHsW1J+dQ09Q10O8tAglAoL3tpulucPkgPX6ifQVzlakQ+EDZxt/IOg1F2z5AWd LrFZs/jvn6QVChVWL58Evf8tvNa9gKuvq2rqTmEdKpW4rW/cfsX64WApFb6AhCDbEXtBpJ qSYXMDGOoRd1YbN+3UGMEJgCDs3mCXN++AuhmfJIq1V/ykhzD+50fE3zCsY9xZtTIJgbVL r9/i8j+yTE4VQ3VkGi+T+ELvjXcZ6mdz6/pPv+BYPtEskW7UgllD8xzVs0eyHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eLqqFqka; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.95 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eLqqFqka; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B0E35B622 X-Spam-Score: -1.95 X-Migadu-Scanner: scn1.migadu.com X-TUID: 2DetOHxfzT9D Stefan Kangas writes: > The attached patch deletes some Emacs 24 compat code. Org mode > supports Emacs 26 or later, according to: > https://orgmode.org/worg/org-maintenance.html#emacs-compatibility Thanks! I have some comments. > ;;; Integration with and fixes for other packages > diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el > index 88072852d..287686c01 100644 > --- a/lisp/org-fold-core.el > +++ b/lisp/org-fold-core.el > ... > +(define-obsolete-function-alias 'org-fold-core--seq-partition #'seq-partition "9.6") > diff --git a/lisp/org-macs.el b/lisp/org-macs.el > index da68d8b8f..07c177b0b 100644 > --- a/lisp/org-macs.el > +++ b/lisp/org-macs.el > @@ -70,18 +70,7 @@ > ... > +(define-obsolete-function-alias 'org-without-partial-completion 'progn "9.6") ^#'progn We usually put obsolete aliases into org-compat.el instead of sprinkling them across the various .el files. Please move the define-obsolete-function-alias statements to org-compat. Best, Ihor