From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wEJCFZLvI2NCcwEAbAwnHQ (envelope-from ) for ; Fri, 16 Sep 2022 05:37:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UCReFJLvI2NEdAAAG6o9tA (envelope-from ) for ; Fri, 16 Sep 2022 05:37:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E9F7E2A7E9 for ; Fri, 16 Sep 2022 05:37:52 +0200 (CEST) Received: from localhost ([::1]:50504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ2An-0008VC-L9 for larch@yhetil.org; Thu, 15 Sep 2022 23:37:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ2A9-0008V1-SP for emacs-orgmode@gnu.org; Thu, 15 Sep 2022 23:37:09 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:43689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZ2A7-0001KC-1z for emacs-orgmode@gnu.org; Thu, 15 Sep 2022 23:37:08 -0400 Received: by mail-pf1-x434.google.com with SMTP id d82so19977226pfd.10 for ; Thu, 15 Sep 2022 20:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=z8aHLMnG9O/Ud+sl5WiLzOfenSMnYVA/u4CRMYkhhH0=; b=pXsfOYf4TVV4WqpOtiNm3tLGlLJV/SBXIcgCT1aWPfRbQwR9hboMvKrmpfWwY2mUWb 2jE28CK0hrWCzLdCJM0sEpEsxQ2Q62Mt6DWY5pocDci4/GMj1aINv1nY40a0Sg4NJ0V2 eIu27QF7QigzhqUW62jtXszWUV/jdaQOGhU/LPfxEk13exVktkU7ITE/r32nf2vPk0Wa 8ZIz+yAijabRESnRRC4Orp4Zy9HaMQii9X8FnuzwfIW5p6NxmI+P1eaf/56cb4K1q+NH ht0y2e1KmHs2B+MHRmyku4eLyRYZbTOgHsjwY5nuyJvMBz8hl5oVb7aRUzJJAODkgKZz P8LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=z8aHLMnG9O/Ud+sl5WiLzOfenSMnYVA/u4CRMYkhhH0=; b=QeBfRv6k0wh7b1NNZvfqZtKGcmBGMkLP+XP1OEE/EOeYDYGbeJ4/33wgFEoOR3XuR+ MENfuuJCziJ1tQqOWuKFXYF6tbssV8l4ieFMIz4OAf0UerNvQOJpIUeJhGiUXOqa5fSK Opw5BN9hcPEKJGOzWCkv5lFaXkjzp6MSlRbj8uX6NFckRtMANUtbCNU9DPuCLIa+EMeZ Q467cLeXRCupHfIzA8R4gaG1F2VoyNKMwsQMH2+neRgB9z5jnIoCTQeLvEcJa53Ul0Mw GLQ89N9BvSJC7SThHijyEEJdhdKMiWI+mGGV8qosXtGgyy9C0vQ+zKIb3VrlkyzpOBv8 mgew== X-Gm-Message-State: ACrzQf2ycczqiXsTD+jNRnC1pF64UzoRKJdqHWqY0hPe5l7g80f6XDIa R+5WxguMhRh//MbQzy64RyM= X-Google-Smtp-Source: AMsMyM71ux+FOGpTEziMk5a3/Z7uNxv35tWLFbUf4+TOYNE6s7tww/2D1XvtfH/3zTIC+EyAikSqdQ== X-Received: by 2002:a63:5702:0:b0:42a:b77b:85b3 with SMTP id l2-20020a635702000000b0042ab77b85b3mr2625409pgb.263.1663299424322; Thu, 15 Sep 2022 20:37:04 -0700 (PDT) Received: from localhost ([1.83.155.65]) by smtp.gmail.com with ESMTPSA id a14-20020a17090aa50e00b001fdc88d206fsm396431pjq.9.2022.09.15.20.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 20:37:03 -0700 (PDT) From: Ihor Radchenko To: Stefan Monnier Cc: emacs-orgmode@gnu.org Subject: Re: Use lexical-scoping in tests In-Reply-To: References: <87illqxhje.fsf@localhost> Date: Fri, 16 Sep 2022 11:38:00 +0800 Message-ID: <878rmkugyv.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=yantar92@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663299473; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=z8aHLMnG9O/Ud+sl5WiLzOfenSMnYVA/u4CRMYkhhH0=; b=nfmWHcEtdXZqoMIT4ZXuygONzonuvsO49n3NSoBfSuwYmFtZ3inn4+Aw3Laat/K/7cjeRP VguBHT8wCTNqWNVNZ6o6jFHXdGQHzI4vvvDd9yt598x6/+sqnKz2U9BNa/LsMELgdYfAzo a3cFacYu2Lo+9NTjgiROQ8Cq2h9t36n35ymF1wMoW8+t1t5LdBSIH7G7Skj9xMLLwQVIue BnItFJTDzt/wbEMbjcknYYiiOJroLpbba6D7nTfEnot7n1AEvrp9m8FI2dKQyaOhqHvnS/ H8kEdPOKLA98apgFIJAxoZguheF7lU1J7E5ZLy3e1gWLydBM8U3EM1cyUjhHAw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663299473; a=rsa-sha256; cv=none; b=tDwDSB9G8lMe979bCxaF84TjUl+TjfRQ6OQ6Wi1jd27fAKlLDwLbFgsY7IUoQssI4EltrP 4y+ZnZ9OS5v4lxmUu6YPGiaeG2puEU3TGGi+RZ+QBCXE0+CT5XwegzbfD1WR1F1PCNVlef 6aZBqiQv7Re8Z2ooq5BTQJwaxl4JIq53vLEt1v/0Gz+uoXXUfL3mB+xI/sXP0I0SdlWNVd bX+8kN6gFreYsSK1lpnluo1r4wVLpP+/UR1RsnWDp8Ia+54F2Pwm6htYwqM33rbmXOyLOk dLvSx8mptB7Df6ro1qEciUrc9uu4uEXuiviPO83ZEI77en5ZWN6nRAQEl34NxQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pXsfOYf4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.83 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pXsfOYf4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E9F7E2A7E9 X-Spam-Score: -1.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: F6jMBxuL3tpD Stefan Monnier writes: >> The fix is in preparation, but obviously I had tested my patch >> incorrectly (i.e. I probably compiled and tested another code than the >> one I had patched). > > OK, here's a better version. As you can see, it's not nearly as simple. Applied onto main + commits addressing all but one FIXME (the one about `find-file' in org-test.el). https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=1a5e3f931c9bbefaefafd4cdcc5f0dfcd1c97769 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=17b51973bd17f26b4dfa0a5d5f198c7e1c8461dd https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6074a22bcb25593bd7644b2695d38f8b41200463 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e3348ccc03b0aa3e8f8b3d0837b91f8285fe161a -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92