emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-babel-script-escape mishandled empty python list
Date: Wed, 12 Oct 2022 19:49:52 +0800	[thread overview]
Message-ID: <878rllw9b3.fsf@localhost> (raw)
In-Reply-To: <87v8opfhk1.fsf@bernoul.li>

Jonas Bernoulli <jonas@bernoul.li> writes:

> `org-babel-script-escape' doesn't handle an empty python list
> correctly; ['a'] => ("a") but [] => [].
>
> #+name: addheader
> #+header: :var rows=""
> #+begin_src python
>   return []
> #+end_src
>
> #+header: :post addheader(*this*)
> #+begin_src emacs-lisp :results table
>   nil
> #+end_src
> #+RESULTS:
> : []
>
> An empty python list is turned into an empty lisp vector instead of
> an empty lisp list.  At least for python, (> (length str) 2) should
> probably be changed to use >=.

Thanks a lot! A reproducer helps a ton.
Fixed on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4c0641837c8570dd8ad7f18c2482411bdc0cda16

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      reply	other threads:[~2022-10-12 11:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 10:43 [BUG] org-babel-script-escape mishandled empty python list Jonas Bernoulli
2022-10-12 11:49 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rllw9b3.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jonas@bernoul.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).