From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cMQ4H6H4Y2PIYQAAbAwnHQ (envelope-from ) for ; Thu, 03 Nov 2022 18:21:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +H4yH6H4Y2NJ7gAA9RJhRA (envelope-from ) for ; Thu, 03 Nov 2022 18:21:37 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 303B9E0BB for ; Thu, 3 Nov 2022 18:21:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqdta-0001kd-3D; Thu, 03 Nov 2022 13:20:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqdtY-0001kT-HY for emacs-orgmode@gnu.org; Thu, 03 Nov 2022 13:20:48 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqdtW-0002Ac-Uf for emacs-orgmode@gnu.org; Thu, 03 Nov 2022 13:20:48 -0400 Received: by mail-pg1-x536.google.com with SMTP id 64so2246910pgc.5 for ; Thu, 03 Nov 2022 10:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZW5D+PxjenoKK40aN9eAd5fycoBgD3AtvJnbUhbNw80=; b=eOyHb9jiwqS9VTeourGM8l7Rh5R7XIemHfkgLxcSeo6nAM9afG24P2RYfF1nYxxFiT kUQ9j0axQhfUiVF2kxyPoUu5IQNjrh4ndT3HlfnyTrPTvA8g55sSQqifpdp7AmEFGHhW 9oZjneexY2GQOBUqBA7/X4XAfhz0MiSMrLA/dX+TO4YjR0YS6pY7SvwJsxGVlxOaBYIh Hd+Norb5ODlRmqpTjbsvHiMrpMh+/vRY0EI0TZUsg0zulzbRLqRvywIGdbCNHQbcw0SX U5CzV7QgZ/XnwAEGoTGjqtPUnhEYoM6zZe0BEzkV6EUPA4gD/Ikb01Fd/8ZF7zeit5a4 5MfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZW5D+PxjenoKK40aN9eAd5fycoBgD3AtvJnbUhbNw80=; b=b8ZXyx4iK5S952rdDd3l0lX65pPj9XNKg04nDazF+C80bAodoY6r8H5dPfHnHKdxLg MdHFQxb9yhdD9iCsgx+snq2A6m6L029Y49M5OeaQjyLZwppidGnGiDHKNY2xy4JmeJwE rM0mtjHW9vWqlka9L3phIhca66k54Lr4nlTrBRgWCF+ntMutAoyBAK2xvvQf6Y8dn1xw VsvxoF3GdyIZ2v2KnP12doxJk5Agt5a1a5K667ONW2nZUoGXX1a8NqRkOEw7DuVRLN+6 SRALiV6RmXryMaEzo0HQW1SRqb/mQh8ldmiJp746wFRXT+NyVL2zcP+qbQo9Ty+YQBHC 3kuw== X-Gm-Message-State: ACrzQf33LSGHUBm9oDmMrQkTQ2zLiXvbMzKzE7DVrIcF8AHRfOGdl4dT n9stg5CtwyTe1umPMPMqfMJnKR5GK9c= X-Google-Smtp-Source: AMsMyM7BoxSxmnr/1FU+0tt2qoTSRff9SZm219lpYzZtl6RA5L0FBXapJL/RZ3wPISgY6+ZK9uNsMA== X-Received: by 2002:a05:6a00:10cf:b0:528:48c3:79e0 with SMTP id d15-20020a056a0010cf00b0052848c379e0mr30995152pfu.18.1667496045410; Thu, 03 Nov 2022 10:20:45 -0700 (PDT) Received: from localhost (157-131-78-143.fiber.dynamic.sonic.net. [157.131.78.143]) by smtp.gmail.com with ESMTPSA id j4-20020a170902c3c400b00177f4ef7970sm972737plj.11.2022.11.03.10.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 10:20:44 -0700 (PDT) From: Jack Kamm To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python? (was: [BUG] ob-python: async session evaluation does not support python-mode.el [9.6-pre (release_9.5.5-2661-g2d040b.dirty @ /home/yantar92/.emacs.d/straight/build/org/)]) In-Reply-To: <87r0yk7bx8.fsf@localhost> References: <87bkprid1d.fsf@localhost> <87mt9am16j.fsf@gmail.com> <87r0yk7bx8.fsf@localhost> Date: Thu, 03 Nov 2022 10:20:43 -0700 Message-ID: <878rkslztg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=jackkamm@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667496097; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZW5D+PxjenoKK40aN9eAd5fycoBgD3AtvJnbUhbNw80=; b=K6CHB2M8DXuS9LRiRzHp4kHkeZmHg3hQIHWrGqsKppuj67/1MPWjYRCBPyLO5tqvOCOcVU eTGy741RFP1J5YjQAwCjFq02szA20bY6TqlXd//EMgvRh2WMG5dcuir1l9sCzM12TnHO6/ Po/7QhFxI/3/zaaxIJQlueBWDpZ8ABr1BKRK3G4fschIMtxJ1qbDyeZgurumDgnbYOZs1B TS2Jz0rgziqfTGxbVCB2eB6y6DVP/UtRI3EGBPuSxyPq9k39BnopsIs8Gxhc+lKBoLulQd uXTFnfzDE66vkSmam9ayA2MoQsj94gCu1Byqvdks1Uy+nJdVXJ+tYIvb6V70rg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667496097; a=rsa-sha256; cv=none; b=K2aG7n2NKWzCkwF5G24f+SbpGB/nhvrTOB2f2eAn/2TgVr1gNFrugSMMRyiSfYgZNb4re3 bkLgv9mmxM+lu6u+2Osk/NlKxBNNNqh8TreGC0iErSirk7r1WU8+hMDcSQYyHZBSWv4Jlm hgwxQreKx0hTYf0DnYSqtiLdn9TqsEz+vuuojhI5zCtc3fzEz2o0F2S7HdSWZBPMmkvicc HhQBOMXquDNrdibD2+qdLslG7AHjnljijdlZ33yJbCZx4OqygpSIe5pxYfku5/Zk0Yt5Iy Gjk6dcmB/7U+WtgkJC5IdZC9NbXvyac7k9yVRKt7nKU5OB97D81oqoQBx8sbbQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eOyHb9ji; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.92 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eOyHb9ji; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 303B9E0BB X-Spam-Score: -5.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: B62yhg7URmg5 Ihor Radchenko writes: > However, supporting python-mode.el integration is difficult for Org > team: neither the current ob-python maintainer nor the rest of Org team > are familiar with python-mode.el. > > The bug discussed above already shows that parts of ob-python do not > work properly with third-party python-mode.el. > > Should we deprecate the support altogether and not bother with the extra > maintenance? Or maybe someone want to volunteer maintaining > python-mode.el integration? Thanks for this summary Ihor. In my experience, supporting both python.el and python-mode.el adds a high maintenance burden to ob-python. I think it would be better if ob-python could focus on python.el only, and a separate ob-python-mode created if there is demand for it. One cause of the higher maintenance burden, is that a lot of functionality needs to be implemented twice to support both modes. Or alternatively, functions need to be written in a way that's agnostic to the python mode -- but this also adds complexity, as working with comint directly can be tricky and bug-prone. Testing is another problem, as there isn't a way to use ob-python with both python modes in the same emacs config. So a separate emacs setup has to be maintained to test that python-mode works, which adds more maintenance headache. If python-mode support is removed, I'd be willing to help create a new ob-python-mode package, so that python-mode users can keep using Babel. However I don't normally use python-mode, so it would be best if a python-mode user could volunteer to help with this as well.