From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2K8xLaCWPmSptQAASxT56A (envelope-from ) for ; Tue, 18 Apr 2023 15:09:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IHsjLaCWPmT9FwAA9RJhRA (envelope-from ) for ; Tue, 18 Apr 2023 15:09:52 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8FC678D88 for ; Tue, 18 Apr 2023 15:09:51 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pol4j-0002aD-C9; Tue, 18 Apr 2023 09:08:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pol4g-0002Zk-K1 for emacs-orgmode@gnu.org; Tue, 18 Apr 2023 09:08:46 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pol4V-00055R-MF for emacs-orgmode@gnu.org; Tue, 18 Apr 2023 09:08:46 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CED4E24021B for ; Tue, 18 Apr 2023 15:08:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681823312; bh=+MRoW7eN2C9o9vvJFkFQq7SKiWtNMsS9I3xNLRbuLEg=; h=From:To:Cc:Subject:Date:From; b=U9NDa7Np5L0YU2udQFDy21Cc1Lq0yynWyRstHNZBl56ImuLa0Muv1KtQ9Z8coJHlZ ClxyrtmGppyg/Lj1e3hfVCFvX+KoMoW8YC0D+XgOBY45exgXgAU52Uvib1Y9vnjH3P VSiVaNHHmJj1bAi/4r3i88q5lzCdtkDV5KNugF1DgfWUuVyRlcCTwwaFTh7s2u0CKP ptMnvDfexv+YDkAHLHtVBvxCBLzPTM74w8Pcypfj2t5iOKDNikwcGruuwWvgcRy18r ydNS6i/IXtqc/5qiXJ0aUIKhXM4dVMGDpEpelp1YcOw2ja3c/KssDsTuD74MQzSsSi eTsxnOBFMX5uw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q14401ZK6z6tsg; Tue, 18 Apr 2023 15:08:32 +0200 (CEST) From: Ihor Radchenko To: Lionel Henry Cc: emacs-orgmode@gnu.org, ESS-core@r-project.org Subject: Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)] In-Reply-To: References: <87ilduqrem.fsf@localhost> <87mt35h3ip.fsf@localhost> Date: Tue, 18 Apr 2023 13:11:03 +0000 Message-ID: <878repgwt4.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=U9NDa7Np; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681823391; a=rsa-sha256; cv=none; b=bGE18Csor250W317z60xln6P86R+o6kWxbmS7teBcKc/MxeeHuLwhmk/PAOQtPc1VhqsTt qr6oihCZhLuOfUfCuMeD0oLHmMAo/2dlvkTVIkjBi3qph8WMjCc/hggUszuGHgvJxPgkMg u5rnZmDIHPEpZIoQszpUzjF+8gP244n8WGmblT6KdJHvT5v4eeGiSew/aa1zdZlnq1U+e/ y/jW2o5SfxVWbfLtfxm4YEFKxZSbZNMcGzn2ZFDwnmuSNs6xNzeLhUWUqZnQDzwxEYdx7M NylHyRxs10GLrcYTuChQkAD5O1BmccEfIQ7pwIyl4xpitCMU2wceTLMo9gI1mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681823391; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1FocJBLwS8x6F+33MCrRuyPjigPtwDPXyERWHIzWiCI=; b=BZf0AbbiridyhATb3tbsWkM9gJZtugYfyY4wzBqhcNirvHH2MWUxdRte7XktSl5m9pEXFT NQEeOmrP3LeH/8gKF4EFcJpahmBpFYMiPr7OjEkDx/LKuY8Q+InGcYy889PNPSPgrKztOY gxJCn+QHQuPPREBNs93DuJQA9XGXM9wqBMVdjwf8nEHDi+Xe9qLIb/v9Ju+o/TNVrfqvs5 3t//z+s8SRIs/uwGIu7zI3Pqs+M2EjDxojXmqAN0EXBOqqilxSED9+Mth5st9IIXmcVvKe sZ6xg6Z8SgtnCqiUy+gSiGVlaGuwNxBcmMi/X2zI3VyleRoBUQfaWt4moT2lyQ== X-Migadu-Spam-Score: -6.81 X-Spam-Score: -6.81 X-Migadu-Queue-Id: 8FC678D88 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=U9NDa7Np; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: CCFADb5OnRhe Lionel Henry writes: > Can you try with the latest commit please? > https://github.com/emacs-ess/ESS/commit/ed6c12ee3dfb1046fb030200f45e75a65b31e49e Works now. Thank you! > By the way, it looks like you're setting the width in the exported > initialization routine rather than just in tests. For user-facing > features at least you probably want to set the width to something that > will produce readable output. You are right. For some reason, I thought that the problem also affects :results value, when we want to convert ESS interactive output into Elisp data. But it was not the case - only :results output has been affected. Since we have no reason to disregard ESS output settings in :results output, I pushed an alternative fix that only affects tests, as you suggested. Do note that the root cause remains on the ESS side - `run-ess-r' in Emacs 27, when called non-interactively, may set line splitting to something strange. I am unsure if it is something that should be fixed on ESS side. I am also unsure if the problem does not happen in other Emacs versions. Fixed, on main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=83e446ea8 I also added a test for :results value when the output is long. Just in case. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3c449cc43 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at