[BUG] org-agenda-tree-to-indirect-buffer does not respect org-indirect-buffer-display value

[BUG] org-agenda-tree-to-indirect-buffer does not respect org-indirect-buffer-display value

[JV]

`org-agenda-tree-to-indirect-buffer' does not respect the
`org-indirect-buffer-display' value of 'current-window unless invoked 
with a prefix arg.

The function does respect all other values for
`org-indirect-buffer-display'. And it does respect the value
'current-window when the function is called with a prefix arg.
However, without prefix arg, 'current-window and 'other-window are 
treated the same and call to `split-window' is made.

Modifying the initial lines of `org-agenda-tree-to-indirect-buffer':

   (if current-prefix-arg
       (org-agenda-do-tree-to-indirect-buffer arg)

to be:

   (if (or current-prefix-arg
           (eq org-indirect-buffer-display 'current-window))
       (org-agenda-do-tree-to-indirect-buffer arg)

produces the behavior I would expect. This may or may not be the ideal 
fix, but it seems viable and simple.

Org mode version 9.6.29
GNU Emacs 29.3

- Jeff

Re: [BUG] org-agenda-tree-to-indirect-buffer does not respect org-indirect-buffer-display value

[Ihor Radchenko]

JV <misc@jeffvalk.com> writes:

> `org-agenda-tree-to-indirect-buffer' does not respect the
> `org-indirect-buffer-display' value of 'current-window unless invoked 
> with a prefix arg.
>
> The function does respect all other values for
> `org-indirect-buffer-display'. And it does respect the value
> 'current-window when the function is called with a prefix arg.
> However, without prefix arg, 'current-window and 'other-window are 
> treated the same and call to `split-window' is made.

Thanks for reporting!
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=db5478108

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>