From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 4GemAse0nmaHpQAA62LTzQ:P1 (envelope-from ) for ; Mon, 22 Jul 2024 19:36:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 4GemAse0nmaHpQAA62LTzQ (envelope-from ) for ; Mon, 22 Jul 2024 21:36:39 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XM9DxXlj; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721676999; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mSWj2U7eitBXKKZV6Msv13LjDVd3yIKA+HPaZYiZCHE=; b=nP4iwLIvukza5LoH8XEOy68BkVzHHOzbyjhn8Qm/61jkPn8mnAN5ujkU1dSuXCn2shMT/2 40pDPlgkmFdD8FiyUOMEeW88y/mGGnJjSjKMORzS0yZbPNtyHEeqCuzhPPUnpjhBjZriRN H1VeuaLiq4qnLno3WYc7TojlIcnsjxQdcrLztN2hvvYQX3/80C418Z0Y142M4g7IxAFwU3 FREOC4OynDx5NxF8+8DyjhBuRUAtemhIVwxEUVS8R34jZ+pjRn1auqjTH9CSM/cbcF1J5t vGQ8L1DoS74pEyYCwhFZWUByFhQ0jfkxOUvi9iWNtXheqtf8TzawLPnCZfF9Uw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XM9DxXlj; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721676999; a=rsa-sha256; cv=none; b=bEkfLc/xAQFMrrb3ytE859KdJ6d2Jw0gMSZGc0+CBlC/EmtmY2/j3ENdQJXSTRR25Q2NaJ rfHmPZVhoUuaUGgoXHIwUsqdBWojRt0fBatwayBnjPvfqYE8fvdzHCE8giNGQMNeXck5Fe PYxA0XNC6gyCkcd4KhI1/0E0wdQG4Q44ZA6ULwvXFSF0d2kVSeGhC7otT/T6EVjRvvZrfF gYqifkW5dtClA+1EeV2pnEvNOdHBh6swsXrlFFFhKqhuUwRBIyg8ET6BLfcUebdhZH02cp oFB9HgBC8dAeQJCeA5kIVUs4WKu/amKZZ58a4824SLlk9Wzq4KD92+rmc8QtVg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 86B4E6DE13 for ; Mon, 22 Jul 2024 21:36:38 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVyp0-0006RB-2J; Mon, 22 Jul 2024 15:35:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVyov-0006PI-P8 for emacs-orgmode@gnu.org; Mon, 22 Jul 2024 15:35:42 -0400 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sVyot-0004nW-Vz for emacs-orgmode@gnu.org; Mon, 22 Jul 2024 15:35:41 -0400 Received: by mail-qv1-xf41.google.com with SMTP id 6a1803df08f44-6b79a8c17bfso4520266d6.1 for ; Mon, 22 Jul 2024 12:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721676937; x=1722281737; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=mSWj2U7eitBXKKZV6Msv13LjDVd3yIKA+HPaZYiZCHE=; b=XM9DxXlj0DsmCWEsReYXTSd58EDFFDyS3If7VlvY2QEQqpoY68C8untj30t+8uv03M EV3uCN06KJ5GlhBeqszPrtBOt4pW2SlLmBVOZoGOygSsZCf71FiF4Bj60bntuo5ETkyH gTBc4fOnruMXFoKyRkz2xBPb7G8FGcuwD0GzoxeB5Ld7/05BvYDLh27tNY6AL+tJIvY2 xcINF+Xc92WadLdYkLBkJGEnRQh67g5aSzUaoM1JP1/xXNqGI+yndZh+aRPDGPPaOMDi tBhh4IrdGlg0JG3WYJKiEZWBIiCZb6Cx91x3RjPF7VmdRq0vnCklkD5BamCZNylI/yab 3z4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721676937; x=1722281737; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mSWj2U7eitBXKKZV6Msv13LjDVd3yIKA+HPaZYiZCHE=; b=P+S4h4ctFt4mOqQdcF7pkD1tK28/9LENvVnbZRJKGJyPky8DCI/oEENBV/PC8FVkEV ZLup1OWUIyGslh7o5+rDQ6VjU+naUvJNDK9DW3dOIGTFMG3CKbnl+S3S2hvuoHH9ASFq G9CpCe5CYrBtWP9ctZPf/mdauRCUibIDo+Qjcog6/IvR+MKGiCzEGrYaWzZOT5/hPAbX ViD/j+8uQ49NBqI8JMmJKNLMBxtzh9n75+SHYlBMITCwGFlDmbyClGpuMmoaqb6vhB/x Ck7fFE6cm3yqvx06nRy3ldXegsBqgr/I4dVZ4VcEkYzMPFydbIhiHt08Dm4Uwh1SKEVk QAqw== X-Forwarded-Encrypted: i=1; AJvYcCWgYSf/UGRszGYQIIGYmwC2lr9Q37Mhhw7/58oDQqBRe2dFONgvFVEhDb8UGiMRWXNAtLgAIeSw3rDDaK7TdnZgqvYjWLg= X-Gm-Message-State: AOJu0YyksXTugMhFPEaV6He1/W+3ksJ2Kfl9gQJACjnLmELFt1x71PG/ LDkk+QZDCdo7n7xRyDPrTXyVgzgPrnIM7F6XnxFnd2AQZs4uWcnwsW7+447l X-Google-Smtp-Source: AGHT+IH0ASCxAVaf3Xn75xP5Lr8R2pso8IkclBoWXqHm+GLeQjI9lYo6Vd9zynH7z6o7Sm/M6a/lrw== X-Received: by 2002:ac8:5808:0:b0:447:e013:755c with SMTP id d75a77b69052e-44fa525dfc1mr71317451cf.4.1721676937355; Mon, 22 Jul 2024 12:35:37 -0700 (PDT) Received: from gnus ([65.93.169.47]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-44f9cd34d9dsm36357131cf.52.2024.07.22.12.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 12:35:36 -0700 (PDT) From: Suhail Singh To: Ihor Radchenko Cc: Suhail Singh , TEC , Org mailing list Subject: Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks In-Reply-To: <877cddmedg.fsf@localhost> (Ihor Radchenko's message of "Mon, 22 Jul 2024 19:10:51 +0000") References: <87v8277ye7.fsf@gmail.com> <877cems1t4.fsf@localhost> <8734o5v1sg.fsf@gmail.com> <87le1tmt8w.fsf@localhost> <87r0bl2vyv.fsf@gmail.com> <87a5i9mh19.fsf@localhost> <87cyn52rm5.fsf@gmail.com> <877cddmedg.fsf@localhost> Date: Mon, 22 Jul 2024 15:35:25 -0400 Message-ID: <878qxt2paa.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::f41; envelope-from=suhailsingh247@gmail.com; helo=mail-qv1-xf41.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -9.75 X-Migadu-Queue-Id: 86B4E6DE13 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -9.75 X-TUID: ZS1WUGO2k3/X Ihor Radchenko writes: > AFAIU, your main point is that you want the patch to land on bugfix. It > will not, regardless whether we add :textarea support or not. While not the answer I had hoped for, I appreciate the clarification. > Next, if you are not interested in adding :textarea support, it is > OK. Adding #+ATTR_HTML support for code blocks and fixed width elements > will still be a welcome improvement (I was just hoping to push you to > contribute a bit more ;)) > > Now, back to your original patch. > May you please factor out adding attributes into a separate function, so > that we avoid duplicating the code? And please announce the change in > the news - people aware of the current behavior might need to know about > the change. Given that I already have some contributions in Org mode and I don't, at present, intend to do the copyright assignment to FSF, could you please confirm: 1. How many lines worth of changes I can still introduce without going over the limit? 2. When implementing such refactoring changes, which lines are counted? >From a feasibility perspective, I suspect it might be better for you (or someone else who's signed the FSF copyright assignment paperwork) to take on the work of applying changes that are similar in spirit to the patch. -- Suhail