From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UPq+BexhLme5JQAAqHPOHw:P1 (envelope-from ) for ; Fri, 08 Nov 2024 19:09:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id UPq+BexhLme5JQAAqHPOHw (envelope-from ) for ; Fri, 08 Nov 2024 20:09:32 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="VSXIR/wc"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731092972; a=rsa-sha256; cv=none; b=t780SulhgYkG9RrtsqNdhwnpU/ukkkd0wHKPLcjfjp1oQoZxNKudwDWrvARmDrb7nJb5Ai cTVBEpDB3d4+cJ8wEqiB6oShYd4jaH6lwZrHZsb6JRTROFFylniBybqqxKxIbf3LSYkrit BsTA23dX63We6r6yxb01eFVkeWo2G/E9n7l2WLQr/3+XDNDsZhFHPV98viHwBhAzKVXN+U rAisVBut6u39AS5RdDE6NvN7gyMfG4HIG/JEdvb9ge/iOfPGopfq28KMtO+oZDVu22GlrH 4IoS9u1cXtgmB0yAPCv5tJBUctBph3e/HZfPzN2RRYyVcKbaLlJrpofhsm8DFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="VSXIR/wc"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731092972; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=eDy/o9Uh+56aaY2g2TOd1UcixC75HybvJKUiFA+TFgc=; b=cdGswSbDvx2bX/zB67rcThHkf1vds5/wWaNlOv7nAM/ioVihi1o6wi2nsyR6WBIP/IgdMN iS5UYPhqFdqJuXWViFW7O+eU2tM0R/H+mgzdpI/y2micy/VeT+CbN48DnDSeN1J8fej8Ff 2C56q9jymwShbaFZ4FS6a08ST8sbQ+dIWHnPfIHPA71nG7urwQtEUQjBClq/pZZtnJQONm HuaV+rIY8qw0ZhJTG6QgbiCroJDsutYHrVbTBpy1h8N8xQ23iagfb1HrcI0tMC2MS1u1Mk YyqekbpWOTVRfOz221im1xLTIyU7mJ9h+oqRALfU2Wj8njZGCUI2Iqpd8p8XTQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74DC171A00 for ; Fri, 08 Nov 2024 20:09:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9ULk-0007zo-9O; Fri, 08 Nov 2024 14:08:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9ULh-0007sF-OT for emacs-orgmode@gnu.org; Fri, 08 Nov 2024 14:08:49 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9ULd-00023H-LU for emacs-orgmode@gnu.org; Fri, 08 Nov 2024 14:08:49 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 124EE240101 for ; Fri, 8 Nov 2024 20:08:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1731092912; bh=z6kJHzBJZdRASGAMwjs/TTVeZHp4BzDvSjhn8lxFu28=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=VSXIR/wcTrkwDG+LtK1SHPFdQQrmY0dUy4yKpdeNBlbFY4oAkynAc/p2SxuASfeZD xentEkljjqF4h+phvX6gXOM1Mk1YuFIEYVTG802AkmWPs8t1wRidiJBCWNHDsjB/Rm qp6s6ec+VMxvmR6a1FkGcZtQA3yFyeLiC8B5Pv/+ReYXoWp85AbuZ7mdzZ25rDk0fQ B7PiQJU0dNDGcF54A3pvr68kF/11RtNkzVPnKKHWWEdRVDvQxsL4RTKoLe8iWxVF6P Un8ubtLQqN2dkaZ29RaxDDE8QxesZfINdS5ZjAYrTnWGG7yW86r4RH7cEEhQCXnVd2 N2X/G0wTjEQWQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XlT4F463Nz9rxD; Fri, 8 Nov 2024 20:08:29 +0100 (CET) From: Ihor Radchenko To: Jarmo Hurri Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-ditaa.el: custom var name, ditaa executable, SVG output, and chararacter encoding In-Reply-To: <87a5eanfys.fsf@iki.fi> References: <875xp476pt.fsf@iki.fi> <87msiggqjm.fsf@localhost> <87a5eanfys.fsf@iki.fi> Date: Fri, 08 Nov 2024 19:10:09 +0000 Message-ID: <878qttwnhq.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.36 X-Spam-Score: -3.36 X-Migadu-Queue-Id: 74DC171A00 X-Migadu-Scanner: mx10.migadu.com X-TUID: 0cMccozRqs6X Jarmo Hurri writes: >>> + (png (cdr (assq :png params))) >>> + (svg (cdr (assq :svg params))) >>> (eps (cdr (assq :eps params))) >> >> I am wondering if we could instead deprecate the :png/:eps parameters >> and instead use the :file extension to decide. > > This could be done, but I do not see much harm in providing an > override. Note that the file extension is used by default. > > So, your choice: is it > a) file extension only > b) file extension with possibility to override with parameters? AFAIU, the current situation is not ideal: if we have something like #+begin_src ditaa :pdf :file foo.eps, the results will be very strange. Moreover, we have API function `org-babel-graphical-output-file' (not used by ob-ditaa) that makes use of :file-ext standard header argument that is serving similar purpose with :eps/:pdf in ob-ditaa (see 16.5 Evaluating Code Blocks section of the manual). So, I view these :ext options that are still used by several babel backends as candidates for deprecation. Certainly, I do not want to make them proliferate in the new features. >>> + (message cmd) >>> + (shell-command cmd) >>> + (when pdf >>> + (let ((pdf-cmd (concat "epstopdf" " " ditaa-out-file " " >>> + "-o=" (org-babel-process-file-name out-file)))) >>> + (message pdf-cmd) >> >> Why message? > > I was originally directed to ob-plantuml, which message's its > command. During the testing of this patch I found messaging useful to > observe what was happening. > > So, your choice: > a) no messaging > b) message always > c) defcustom a toggle for messaging? I'd prefer no messaging as it serves no clear purpose to the user. For debugging purposes, one can always do M-x trace-function shell-command > And, finally, should I add myself as the maintainer? That would be great. Thanks! I assume that you already have access to savannah as you are listed as the maintainer of ob-processing. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at